fix CREATE

packages/time-series/lib/commands/CREATE.spec.ts

@@ -1,80 +1,80 @@
 import { strict as assert } from 'assert';
 import { TimeSeriesDuplicatePolicies, TimeSeriesEncoding } from '.';
 import testUtils, { GLOBAL } from '../test-utils';
-import { transformArguments } from './CREATE';
+import CREATE from './CREATE';
 
 describe('CREATE', () => {
-    describe('transformArguments', () => {
+  describe('transformArguments', () => {
-        it('without options', () => {
+    it('without options', () => {
-            assert.deepEqual(
+      assert.deepEqual(
-                transformArguments('key'),
+        CREATE.transformArguments('key'),
-                ['TS.CREATE', 'key']
+        ['TS.CREATE', 'key']
-            );
+      );
-        });
-
-        it('with RETENTION', () => {
-            assert.deepEqual(
-                transformArguments('key', {
-                    RETENTION: 1
-                }),
-                ['TS.CREATE', 'key', 'RETENTION', '1']
-            );
-        });
-
-        it('with ENCODING', () => {
-            assert.deepEqual(
-                transformArguments('key', {
-                    ENCODING: TimeSeriesEncoding.UNCOMPRESSED
-                }),
-                ['TS.CREATE', 'key', 'ENCODING', 'UNCOMPRESSED']
-            );
-        });
-
-        it('with CHUNK_SIZE', () => {
-            assert.deepEqual(
-                transformArguments('key', {
-                    CHUNK_SIZE: 1
-                }),
-                ['TS.CREATE', 'key', 'CHUNK_SIZE', '1']
-            );
-        });
-
-        it('with DUPLICATE_POLICY', () => {
-            assert.deepEqual(
-                transformArguments('key', {
-                    DUPLICATE_POLICY: TimeSeriesDuplicatePolicies.BLOCK
-                }),
-                ['TS.CREATE', 'key', 'DUPLICATE_POLICY', 'BLOCK']
-            );
-        });
-
-        it('with LABELS', () => {
-            assert.deepEqual(
-                transformArguments('key', {
-                    LABELS: { label: 'value' }
-                }),
-                ['TS.CREATE', 'key', 'LABELS', 'label', 'value']
-            );
-        });
-
-        it('with RETENTION, ENCODING, CHUNK_SIZE, DUPLICATE_POLICY, LABELS', () => {
-            assert.deepEqual(
-                transformArguments('key', {
-                    RETENTION: 1,
-                    ENCODING: TimeSeriesEncoding.UNCOMPRESSED,
-                    CHUNK_SIZE: 1,
-                    DUPLICATE_POLICY: TimeSeriesDuplicatePolicies.BLOCK,
-                    LABELS: { label: 'value' }
-                }),
-                ['TS.CREATE', 'key', 'RETENTION', '1', 'ENCODING', 'UNCOMPRESSED', 'CHUNK_SIZE', '1', 'DUPLICATE_POLICY', 'BLOCK', 'LABELS', 'label', 'value']
-            );
-        });
     });
 
-    testUtils.testWithClient('client.ts.create', async client => {
+    it('with RETENTION', () => {
-        assert.equal(
+      assert.deepEqual(
-            await client.ts.create('key'),
+        CREATE.transformArguments('key', {
-            'OK'
+          RETENTION: 1
-        );
+        }),
-    }, GLOBAL.SERVERS.OPEN);
+        ['TS.CREATE', 'key', 'RETENTION', '1']
+      );
+    });
+
+    it('with ENCODING', () => {
+      assert.deepEqual(
+        CREATE.transformArguments('key', {
+          ENCODING: TimeSeriesEncoding.UNCOMPRESSED
+        }),
+        ['TS.CREATE', 'key', 'ENCODING', 'UNCOMPRESSED']
+      );
+    });
+
+    it('with CHUNK_SIZE', () => {
+      assert.deepEqual(
+        CREATE.transformArguments('key', {
+          CHUNK_SIZE: 1
+        }),
+        ['TS.CREATE', 'key', 'CHUNK_SIZE', '1']
+      );
+    });
+
+    it('with DUPLICATE_POLICY', () => {
+      assert.deepEqual(
+        CREATE.transformArguments('key', {
+          DUPLICATE_POLICY: TimeSeriesDuplicatePolicies.BLOCK
+        }),
+        ['TS.CREATE', 'key', 'DUPLICATE_POLICY', 'BLOCK']
+      );
+    });
+
+    it('with LABELS', () => {
+      assert.deepEqual(
+        CREATE.transformArguments('key', {
+          LABELS: { label: 'value' }
+        }),
+        ['TS.CREATE', 'key', 'LABELS', 'label', 'value']
+      );
+    });
+
+    it('with RETENTION, ENCODING, CHUNK_SIZE, DUPLICATE_POLICY, LABELS', () => {
+      assert.deepEqual(
+        CREATE.transformArguments('key', {
+          RETENTION: 1,
+          ENCODING: TimeSeriesEncoding.UNCOMPRESSED,
+          CHUNK_SIZE: 1,
+          DUPLICATE_POLICY: TimeSeriesDuplicatePolicies.BLOCK,
+          LABELS: { label: 'value' }
+        }),
+        ['TS.CREATE', 'key', 'RETENTION', '1', 'ENCODING', 'UNCOMPRESSED', 'CHUNK_SIZE', '1', 'DUPLICATE_POLICY', 'BLOCK', 'LABELS', 'label', 'value']
+      );
+    });
+  });
+
+  testUtils.testWithClient('client.ts.create', async client => {
+    assert.equal(
+      await client.ts.create('key'),
+      'OK'
+    );
+  }, GLOBAL.SERVERS.OPEN);
 });

packages/time-series/lib/commands/CREATE.ts

@@ -1,25 +1,27 @@
 import {
-    pushRetentionArgument,
+  pushRetentionArgument,
-    TimeSeriesEncoding,
+  TimeSeriesEncoding,
-    pushEncodingArgument,
+  pushEncodingArgument,
-    pushChunkSizeArgument,
+  pushChunkSizeArgument,
-    TimeSeriesDuplicatePolicies,
+  TimeSeriesDuplicatePolicies,
-    Labels,
+  Labels,
-    pushLabelsArgument,
+  pushLabelsArgument,
-    pushDuplicatePolicy
+  pushDuplicatePolicy
 } from '.';
+import { RedisArgument, SimpleStringReply, Command } from '@redis/client/dist/lib/RESP/types';
 
-export const FIRST_KEY_INDEX = 1;
+export interface TsCreateOptions {
-
+  RETENTION?: number;
-interface CreateOptions {
+  ENCODING?: TimeSeriesEncoding;
-    RETENTION?: number;
+  CHUNK_SIZE?: number;
-    ENCODING?: TimeSeriesEncoding;
+  DUPLICATE_POLICY?: TimeSeriesDuplicatePolicies;
-    CHUNK_SIZE?: number;
+  LABELS?: Labels;
-    DUPLICATE_POLICY?: TimeSeriesDuplicatePolicies;
-    LABELS?: Labels;
 }
 
-export function transformArguments(key: string, options?: CreateOptions): Array<string> {
+export default {
+  FIRST_KEY_INDEX: 1,
+  IS_READ_ONLY: false,
+  transformArguments(key: RedisArgument, options?: TsCreateOptions) {
     const args = ['TS.CREATE', key];
 
     pushRetentionArgument(args, options?.RETENTION);
@@ -33,6 +35,6 @@ export function transformArguments(key: string, options?: CreateOptions): Array<
     pushLabelsArgument(args, options?.LABELS);
 
     return args;
-}
+  },
-
+  transformReply: undefined as unknown as () => SimpleStringReply<'OK'>
-export declare function transformReply(): 'OK';
+} as const satisfies Command;