redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-09 00:22:08 +03:00
Code Activity

fixes #2524 delaying graceful exit while pingInterval is set (#2525)

Browse Source 
* fixes #2524

* `clearTimeout` in `disconnect` too

---------

Co-authored-by: Leibale Eidelman <me@leibale.com>
This commit is contained in:
Joren Vandeweyer
2023-08-23 19:20:20 +02:00
committed by GitHub
parent 259e9b2e1f
commit bc8abd5a38
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/client/lib/client/index.ts
View File

@@ -683,6 +683,7 @@ export default class RedisClient<
QUIT(): Promise<string> { QUIT(): Promise<string> {
return this.#socket.quit(async () => { return this.#socket.quit(async () => {
if (this.#pingTimer) clearTimeout(this.#pingTimer);
const quitPromise = this.#queue.addCommand<string>(['QUIT']); const quitPromise = this.#queue.addCommand<string>(['QUIT']);
this.#tick(); this.#tick();
const [reply] = await Promise.all([ const [reply] = await Promise.all([
@@ -804,6 +805,7 @@ export default class RedisClient<
} }
async disconnect(): Promise<void> { async disconnect(): Promise<void> {
if (this.#pingTimer) clearTimeout(this.#pingTimer);
this.#queue.flushAll(new DisconnectsClientError()); this.#queue.flushAll(new DisconnectsClientError());
this.#socket.disconnect(); this.#socket.disconnect();
await this.#destroyIsolationPool(); await this.#destroyIsolationPool();