V5 bringing RESP3, Sentinel and TypeMapping to node-redis

RESP3 Support
   - Some commands responses in RESP3 aren't stable yet and therefore return an "untyped" ReplyUnion.
 
Sentinel

TypeMapping

Correctly types Multi commands

Note: some API changes to be further documented in v4-to-v5.md

packages/json/lib/commands/SET.ts

@@ -1,25 +1,38 @@
+import { RedisArgument, SimpleStringReply, NullReply, Command } from '@redis/client/dist/lib/RESP/types';
 import { RedisJSON, transformRedisJsonArgument } from '.';
 
-export const FIRST_KEY_INDEX = 1;
-
-interface NX {
-    NX: true;
+export interface JsonSetOptions {
+  condition?: 'NX' | 'XX';
+  /**
+   * @deprecated Use `{ condition: 'NX' }` instead.
+   */
+  NX?: boolean;
+  /**
+   * @deprecated Use `{ condition: 'XX' }` instead.
+   */
+  XX?: boolean;
 }
 
-interface XX {
-    XX: true;
-}
-
-export function transformArguments(key: string, path: string, json: RedisJSON, options?: NX | XX): Array<string> {
+export default {
+  FIRST_KEY_INDEX: 1,
+  IS_READ_ONLY: false,
+  transformArguments(
+    key: RedisArgument,
+    path: RedisArgument,
+    json: RedisJSON,
+    options?: JsonSetOptions
+  ) {
     const args = ['JSON.SET', key, path, transformRedisJsonArgument(json)];
 
-    if ((<NX>options)?.NX) {
-        args.push('NX');
-    } else if ((<XX>options)?.XX) {
-        args.push('XX');
+    if (options?.condition) {
+      args.push(options?.condition);
+    } else if (options?.NX) {
+      args.push('NX');
+    } else if (options?.XX) {
+      args.push('XX');
     }
 
     return args;
-}
-
-export declare function transformReply(): 'OK' | null;
+  },
+  transformReply: undefined as unknown as () => SimpleStringReply<'OK'> | NullReply
+} as const satisfies Command;