redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-04 15:02:09 +03:00
Code Activity

V5 bringing RESP3, Sentinel and TypeMapping to node-redis

Browse Source 
RESP3 Support
   - Some commands responses in RESP3 aren't stable yet and therefore return an "untyped" ReplyUnion.
 
Sentinel

TypeMapping

Correctly types Multi commands

Note: some API changes to be further documented in v4-to-v5.md
This commit is contained in:
Shaya Potter
2024-10-15 17:46:52 +03:00
committed by GitHub
parent 2fc79bdfb3
commit b2d35c5286
1174 changed files with 45931 additions and 36274 deletions
Download Patch File Download Diff File Expand all files Collapse all files

286
packages/client/lib/commands/XREADGROUP.spec.ts
View File

@@ -1,153 +1,157 @@
import { strict as assert } from 'assert';
import { strict as assert } from 'node:assert';
import testUtils, { GLOBAL } from '../test-utils';
import { FIRST_KEY_INDEX, transformArguments } from './XREADGROUP';
import XREADGROUP from './XREADGROUP';
describe('XREADGROUP', () => {
describe('FIRST_KEY_INDEX', () => {
it('single stream', () => {
assert.equal(
FIRST_KEY_INDEX('', '', { key: 'key', id: '' }),
'key'
);
});
it('multiple streams', () => {
assert.equal(
FIRST_KEY_INDEX('', '', [{ key: '1', id: '' }, { key: '2', id: '' }]),
'1'
);
});
describe('FIRST_KEY_INDEX', () => {
it('single stream', () => {
assert.equal(
XREADGROUP.FIRST_KEY_INDEX('', '', { key: 'key', id: '' }),
'key'
);
});
describe('transformArguments', () => {
it('single stream', () => {
assert.deepEqual(
transformArguments('group', 'consumer', {
key: 'key',
id: '0'
}),
['XREADGROUP', 'GROUP', 'group', 'consumer', 'STREAMS', 'key', '0']
);
});
it('multiple streams', () => {
assert.equal(
XREADGROUP.FIRST_KEY_INDEX('', '', [{ key: '1', id: '' }, { key: '2', id: '' }]),
'1'
);
});
});
it('multiple streams', () => {
assert.deepEqual(
transformArguments('group', 'consumer', [{
key: '1',
id: '0'
}, {
key: '2',
id: '0'
}]),
['XREADGROUP', 'GROUP', 'group', 'consumer', 'STREAMS', '1', '2', '0', '0']
);
});
it('with COUNT', () => {
assert.deepEqual(
transformArguments('group', 'consumer', {
key: 'key',
id: '0'
}, {
COUNT: 1
}),
['XREADGROUP', 'GROUP', 'group', 'consumer', 'COUNT', '1', 'STREAMS', 'key', '0']
);
});
it('with BLOCK', () => {
assert.deepEqual(
transformArguments('group', 'consumer', {
key: 'key',
id: '0'
}, {
BLOCK: 0
}),
['XREADGROUP', 'GROUP', 'group', 'consumer', 'BLOCK', '0', 'STREAMS', 'key', '0']
);
});
it('with NOACK', () => {
assert.deepEqual(
transformArguments('group', 'consumer', {
key: 'key',
id: '0'
}, {
NOACK: true
}),
['XREADGROUP', 'GROUP', 'group', 'consumer', 'NOACK', 'STREAMS', 'key', '0']
);
});
it('with COUNT, BLOCK, NOACK', () => {
assert.deepEqual(
transformArguments('group', 'consumer', {
key: 'key',
id: '0'
}, {
COUNT: 1,
BLOCK: 0,
NOACK: true
}),
['XREADGROUP', 'GROUP', 'group', 'consumer', 'COUNT', '1', 'BLOCK', '0', 'NOACK', 'STREAMS', 'key', '0']
);
});
describe('transformArguments', () => {
it('single stream', () => {
assert.deepEqual(
XREADGROUP.transformArguments('group', 'consumer', {
key: 'key',
id: '0-0'
}),
['XREADGROUP', 'GROUP', 'group', 'consumer', 'STREAMS', 'key', '0-0']
);
});
describe('client.xReadGroup', () => {
testUtils.testWithClient('null', async client => {
const [, readGroupReply] = await Promise.all([
client.xGroupCreate('key', 'group', '$', {
MKSTREAM: true
}),
client.xReadGroup('group', 'consumer', {
key: 'key',
id: '>'
})
]);
assert.equal(readGroupReply, null);
}, GLOBAL.SERVERS.OPEN);
testUtils.testWithClient('with a message', async client => {
const [, id, readGroupReply] = await Promise.all([
client.xGroupCreate('key', 'group', '$', {
MKSTREAM: true
}),
client.xAdd('key', '*', { field: 'value' }),
client.xReadGroup('group', 'consumer', {
key: 'key',
id: '>'
})
]);
assert.deepEqual(readGroupReply, [{
name: 'key',
messages: [{
id,
message: Object.create(null, {
field: {
value: 'value',
configurable: true,
enumerable: true
}
})
}]
}]);
}, GLOBAL.SERVERS.OPEN);
it('multiple streams', () => {
assert.deepEqual(
XREADGROUP.transformArguments('group', 'consumer', [{
key: '1',
id: '0-0'
}, {
key: '2',
id: '0-0'
}]),
['XREADGROUP', 'GROUP', 'group', 'consumer', 'STREAMS', '1', '2', '0-0', '0-0']
);
});
testUtils.testWithCluster('cluster.xReadGroup', async cluster => {
const [, readGroupReply] = await Promise.all([
cluster.xGroupCreate('key', 'group', '$', {
MKSTREAM: true
}),
cluster.xReadGroup('group', 'consumer', {
key: 'key',
id: '>'
})
]);
it('with COUNT', () => {
assert.deepEqual(
XREADGROUP.transformArguments('group', 'consumer', {
key: 'key',
id: '0-0'
}, {
COUNT: 1
}),
['XREADGROUP', 'GROUP', 'group', 'consumer', 'COUNT', '1', 'STREAMS', 'key', '0-0']
);
});
assert.equal(readGroupReply, null);
}, GLOBAL.CLUSTERS.OPEN);
it('with BLOCK', () => {
assert.deepEqual(
XREADGROUP.transformArguments('group', 'consumer', {
key: 'key',
id: '0-0'
}, {
BLOCK: 0
}),
['XREADGROUP', 'GROUP', 'group', 'consumer', 'BLOCK', '0', 'STREAMS', 'key', '0-0']
);
});
it('with NOACK', () => {
assert.deepEqual(
XREADGROUP.transformArguments('group', 'consumer', {
key: 'key',
id: '0-0'
}, {
NOACK: true
}),
['XREADGROUP', 'GROUP', 'group', 'consumer', 'NOACK', 'STREAMS', 'key', '0-0']
);
});
it('with COUNT, BLOCK, NOACK', () => {
assert.deepEqual(
XREADGROUP.transformArguments('group', 'consumer', {
key: 'key',
id: '0-0'
}, {
COUNT: 1,
BLOCK: 0,
NOACK: true
}),
['XREADGROUP', 'GROUP', 'group', 'consumer', 'COUNT', '1', 'BLOCK', '0', 'NOACK', 'STREAMS', 'key', '0-0']
);
});
});
testUtils.testAll('xReadGroup - null', async client => {
const [, readGroupReply] = await Promise.all([
client.xGroupCreate('key', 'group', '$', {
MKSTREAM: true
}),
client.xReadGroup('group', 'consumer', {
key: 'key',
id: '>'
})
]);
assert.equal(readGroupReply, null);
}, {
client: GLOBAL.SERVERS.OPEN,
cluster: GLOBAL.CLUSTERS.OPEN
});
testUtils.testAll('xReadGroup - with a message', async client => {
const [, id, readGroupReply] = await Promise.all([
client.xGroupCreate('key', 'group', '$', {
MKSTREAM: true
}),
client.xAdd('key', '*', { field: 'value' }),
client.xReadGroup('group', 'consumer', {
key: 'key',
id: '>'
})
]);
// FUTURE resp3 compatible
const obj = Object.assign(Object.create(null), {
'key': [{
id: id,
message: Object.create(null, {
field: {
value: 'value',
configurable: true,
enumerable: true
}
})
}]
});
// v4 compatible
const expected = [{
name: 'key',
messages: [{
id: id,
message: Object.assign(Object.create(null), {
field: 'value'
})
}]
}];
assert.deepStrictEqual(readGroupReply, expected);
}, {
client: GLOBAL.SERVERS.OPEN,
cluster: GLOBAL.CLUSTERS.OPEN
});
});