V5 bringing RESP3, Sentinel and TypeMapping to node-redis

RESP3 Support
   - Some commands responses in RESP3 aren't stable yet and therefore return an "untyped" ReplyUnion.
 
Sentinel

TypeMapping

Correctly types Multi commands

Note: some API changes to be further documented in v4-to-v5.md

packages/bloom/lib/commands/count-min-sketch/MERGE.ts

@@ -1,37 +1,37 @@
-export const FIRST_KEY_INDEX = 1;
+import { RedisArgument, SimpleStringReply, Command } from '@redis/client/dist/lib/RESP/types';
 
-interface Sketch {
-    name: string;
-    weight: number;
+interface BfMergeSketch {
+  name: RedisArgument;
+  weight: number;
 }
 
-type Sketches = Array<string> | Array<Sketch>;
+export type BfMergeSketches = Array<RedisArgument> | Array<BfMergeSketch>;
 
-export function transformArguments(dest: string, src: Sketches): Array<string> {
-    const args = [
-        'CMS.MERGE',
-        dest,
-        src.length.toString()
-    ];
+export default {
+  FIRST_KEY_INDEX: 1,
+  IS_READ_ONLY: false,
+  transformArguments(
+    destination: RedisArgument,
+    source: BfMergeSketches
+  ) {
+    let args = ['CMS.MERGE', destination, source.length.toString()];
 
-    if (isStringSketches(src)) {
-        args.push(...src);
+    if (isPlainSketches(source)) {
+      args = args.concat(source);
     } else {
-        for (const sketch of src) {
-            args.push(sketch.name);
-        }
-
-        args.push('WEIGHTS');
-        for (const sketch of src) {
-            args.push(sketch.weight.toString());
-        }
+      const { length } = args;
+      args[length + source.length] = 'WEIGHTS';
+      for (let i = 0; i < source.length; i++) {
+        args[length + i] = source[i].name;
+        args[length + source.length + i + 1] = source[i].weight.toString();
+      }
     }
 
     return args;
-}
+  },
+  transformReply: undefined as unknown as () => SimpleStringReply<'OK'>
+} as const satisfies Command;
 
-function isStringSketches(src: Sketches): src is Array<string> {
-    return typeof src[0] === 'string';
+function isPlainSketches(src: BfMergeSketches): src is Array<RedisArgument> {
+  return typeof src[0] === 'string' || src[0] instanceof Buffer;
 }
-
-export declare function transformReply(): 'OK';