redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-04 15:02:09 +03:00
Code Activity

#2038 Resolve legacy mode hGetAll returning in the wrong format compared to v3 results (#2367)

Browse Source 
* Ensure that transformReply is optionally passed through to commands in legacy mode within multi

* Execute transformReply on legacy #sendCommand

* Scope transform changes to hGetAll

* Extensible method of transforming legacy replies, expands RedisCommand interface

* check `TRANSFORM_LEGACY_REPLY` on client creation (rather then on command exec), add tests

Co-authored-by: Leibale Eidelman <me@leibale.com>
This commit is contained in:
Brandon
2023-01-18 10:54:29 -07:00
committed by GitHub
parent e895fa1d71
commit aa75ee49c6
5 changed files with 97 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/client/lib/commands/HGETALL.ts
View File

@@ -4,6 +4,8 @@ export const FIRST_KEY_INDEX = 1;
export const IS_READ_ONLY = true;
export const TRANSFORM_LEGACY_REPLY = true;
export function transformArguments(key: RedisCommandArgument): RedisCommandArguments {
return ['HGETALL', key];
}

1
packages/client/lib/commands/index.ts
View File

@@ -11,6 +11,7 @@ export type RedisCommandArguments = Array<RedisCommandArgument> & { preserve?: u
export interface RedisCommand {
FIRST_KEY_INDEX?: number | ((...args: Array<any>) => RedisCommandArgument | undefined);
IS_READ_ONLY?: boolean;
TRANSFORM_LEGACY_REPLY?: boolean;
transformArguments(this: void, ...args: Array<any>): RedisCommandArguments;
transformReply?(this: void, reply: any, preserved?: any): any;
}