redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-09 00:22:08 +03:00
Code Activity

Inherit the name property in the error classes

Browse Source
This commit is contained in:
Ruben Bridgewater
2016-05-31 15:11:57 +02:00
parent c1f7755142
commit a0c7431787
2 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
lib/customErrors.js
View File

@@ -4,11 +4,6 @@ var util = require('util');
function AbortError (obj) { function AbortError (obj) {
Error.captureStackTrace(this, this.constructor); Error.captureStackTrace(this, this.constructor);
Object.defineProperty(this, 'name', {
value: 'AbortError',
configurable: true,
writable: true
});
Object.defineProperty(this, 'message', { Object.defineProperty(this, 'message', {
value: obj.message || '', value: obj.message || '',
configurable: true, configurable: true,
@@ -21,11 +16,6 @@ function AbortError (obj) {
function AggregateError (obj) { function AggregateError (obj) {
Error.captureStackTrace(this, this.constructor); Error.captureStackTrace(this, this.constructor);
Object.defineProperty(this, 'name', {
value: 'AggregateError',
configurable: true,
writable: true
});
Object.defineProperty(this, 'message', { Object.defineProperty(this, 'message', {
value: obj.message || '', value: obj.message || '',
configurable: true, configurable: true,
@@ -39,6 +29,17 @@ function AggregateError (obj) {
util.inherits(AbortError, Error); util.inherits(AbortError, Error);
util.inherits(AggregateError, AbortError); util.inherits(AggregateError, AbortError);
Object.defineProperty(AbortError.prototype, 'name', {
value: 'AbortError',
// configurable: true,
writable: true
});
Object.defineProperty(AggregateError.prototype, 'name', {
value: 'AggregateError',
// configurable: true,
writable: true
});
module.exports = { module.exports = {
AbortError: AbortError, AbortError: AbortError,
AggregateError: AggregateError AggregateError: AggregateError

8
test/custom_errors.spec.js
View File

@@ -24,11 +24,11 @@ describe('errors', function () {
assert.strictEqual(e.message, 'hello world'); assert.strictEqual(e.message, 'hello world');
assert.strictEqual(e.name, 'weird'); assert.strictEqual(e.name, 'weird');
assert.strictEqual(e.property, true); assert.strictEqual(e.property, true);
assert.strictEqual(Object.keys(e).length, 1); assert.strictEqual(Object.keys(e).length, 2);
assert(e instanceof Error); assert(e instanceof Error);
assert(e instanceof errors.AbortError); assert(e instanceof errors.AbortError);
assert(delete e.name); assert(delete e.name);
assert.strictEqual(e.name, 'Error'); assert.strictEqual(e.name, 'AbortError');
}); });
it('should change name and message', function () { it('should change name and message', function () {
@@ -65,12 +65,12 @@ describe('errors', function () {
assert.strictEqual(e.message, 'hello world'); assert.strictEqual(e.message, 'hello world');
assert.strictEqual(e.name, 'weird'); assert.strictEqual(e.name, 'weird');
assert.strictEqual(e.property, true); assert.strictEqual(e.property, true);
assert.strictEqual(Object.keys(e).length, 1); assert.strictEqual(Object.keys(e).length, 2);
assert(e instanceof Error); assert(e instanceof Error);
assert(e instanceof errors.AggregateError); assert(e instanceof errors.AggregateError);
assert(e instanceof errors.AbortError); assert(e instanceof errors.AbortError);
assert(delete e.name); assert(delete e.name);
assert.strictEqual(e.name, 'Error'); assert.strictEqual(e.name, 'AggregateError');
}); });
it('should change name and message', function () { it('should change name and message', function () {