slight refactor from code review

smoke test large list of commands ported more tests to mocha, some slight cleanup in tests move sinon and uuid to dev dependencies finished porting eval tests over to mocha rebased mocha testing branch with master ported client and script tests ported watch tests ported detect_buffers tests ported unref tests ported auth tests over to mocha ported idle and no_delay tests ported hlen, hset continuing marching forward ported hincrby, sinter, sort, pubsub tests. improved logic in redis-process, I was still occasionally having issues where redis failed to exit. switch back to default test command ported del, exists, hlen, keys, randomkey, type cleanup based on what I've learned so far from refactor. we now start and stop redis less often. moved tests to their final resting place finished porting node_redis client tests ported hgetall, mget, msetnx, rename, renamenx, setex, setnx ported hgetall, mget, msetnx, rename, renamenx, setex, setnx ported queue tests to mocha amalgamated some of the helper logic ported sadd, scard, sismember, srem, utf-8
2025-08-04 15:02:09 +03:00 · 2015-07-22 20:59:08 -07:00
parent 04fe11b0f5
commit a0832c3744
54 changed files with 3013 additions and 2593 deletions
--- a/test/commands/hset.spec.js
+++ b/test/commands/hset.spec.js
@@ -0,0 +1,70 @@
+var assert = require("assert");
+var config = require("../lib/config");
+var helper = require("../helper");
+var redis = config.redis;
+
+describe("The 'hset' method", function () {
+
+    function allTests(parser, ip) {
+        var args = config.configureClient(parser, ip);
+
+        describe("using " + parser + " and " + ip, function () {
+            var client;
+            var hash = 'test hash';
+
+            beforeEach(function (done) {
+                client = redis.createClient.apply(redis.createClient, args);
+                client.once("error", done);
+                client.once("connect", function () {
+                    client.flushdb(done);
+                });
+            });
+
+            it('allows a value to be set in a hash', function (done) {
+                var field = new Buffer("0123456789");
+                var value = new Buffer("abcdefghij");
+
+                client.HSET(hash, field, value, helper.isNumber(1));
+                client.HGET(hash, field, helper.isString(value.toString(), done));
+            });
+
+            it('handles an empty value', function (done) {
+                var field = new Buffer("0123456789");
+                var value = new Buffer(0);
+
+                client.HSET(hash, field, value, helper.isNumber(1));
+                client.HGET([hash, field], helper.isString("", done));
+            });
+
+            it('handles empty key and value', function (done) {
+                var field = new Buffer(0);
+                var value = new Buffer(0);
+                client.HSET([hash, field, value], function (err, res) {
+                    assert.strictEqual(res, 1);
+                    client.HSET(hash, field, value, helper.isNumber(0, done));
+                });
+            });
+
+            it('does not error when a buffer and array are set as fields on the same hash', function (done) {
+                var hash = "test hash"
+                var field1 = "buffer"
+                var value1 = new Buffer("abcdefghij")
+                var field2 = "array"
+                var value2 = ["array contents"]
+
+                client.HMSET(hash, field1, value1, field2, value2, helper.isString("OK", done));
+            });
+
+            afterEach(function () {
+                client.end();
+            });
+        });
+    }
+
+    ['javascript', 'hiredis'].forEach(function (parser) {
+        allTests(parser, "/tmp/redis.sock");
+        ['IPv4', 'IPv6'].forEach(function (ip) {
+            allTests(parser, ip);
+        })
+    });
+});