redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-07 13:22:56 +03:00
Code Activity

fix ADD

Browse Source
This commit is contained in:
dovi
2023-07-05 14:17:51 -04:00
parent de7e2b85c4
commit 935b9cbb60
2 changed files with 106 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
packages/time-series/lib/commands/ADD.spec.ts
View File

@@ -1,20 +1,20 @@
import { strict as assert } from 'assert'; import { strict as assert } from 'assert';
import testUtils, { GLOBAL } from '../test-utils'; import testUtils, { GLOBAL } from '../test-utils';
import { transformArguments } from './ADD'; import ADD from './ADD';
import { TimeSeriesDuplicatePolicies, TimeSeriesEncoding } from '.'; import { TimeSeriesDuplicatePolicies, TimeSeriesEncoding } from '.';
describe('ADD', () => { describe('TS.ADD', () => {
describe('transformArguments', () => { describe('transformArguments', () => {
it('without options', () => { it('without options', () => {
assert.deepEqual( assert.deepEqual(
transformArguments('key', '*', 1), ADD.transformArguments('key', '*', 1),
['TS.ADD', 'key', '*', '1'] ['TS.ADD', 'key', '*', '1']
); );
}); });
it('with RETENTION', () => { it('with RETENTION', () => {
assert.deepEqual( assert.deepEqual(
transformArguments('key', '*', 1, { ADD.transformArguments('key', '*', 1, {
RETENTION: 1 RETENTION: 1
}), }),
['TS.ADD', 'key', '*', '1', 'RETENTION', '1'] ['TS.ADD', 'key', '*', '1', 'RETENTION', '1']
@@ -23,7 +23,7 @@ describe('ADD', () => {
it('with ENCODING', () => { it('with ENCODING', () => {
assert.deepEqual( assert.deepEqual(
transformArguments('key', '*', 1, { ADD.transformArguments('key', '*', 1, {
ENCODING: TimeSeriesEncoding.UNCOMPRESSED ENCODING: TimeSeriesEncoding.UNCOMPRESSED
}), }),
['TS.ADD', 'key', '*', '1', 'ENCODING', 'UNCOMPRESSED'] ['TS.ADD', 'key', '*', '1', 'ENCODING', 'UNCOMPRESSED']
@@ -32,7 +32,7 @@ describe('ADD', () => {
it('with CHUNK_SIZE', () => { it('with CHUNK_SIZE', () => {
assert.deepEqual( assert.deepEqual(
transformArguments('key', '*', 1, { ADD.transformArguments('key', '*', 1, {
CHUNK_SIZE: 1 CHUNK_SIZE: 1
}), }),
['TS.ADD', 'key', '*', '1', 'CHUNK_SIZE', '1'] ['TS.ADD', 'key', '*', '1', 'CHUNK_SIZE', '1']
@@ -41,7 +41,7 @@ describe('ADD', () => {
it('with ON_DUPLICATE', () => { it('with ON_DUPLICATE', () => {
assert.deepEqual( assert.deepEqual(
transformArguments('key', '*', 1, { ADD.transformArguments('key', '*', 1, {
ON_DUPLICATE: TimeSeriesDuplicatePolicies.BLOCK ON_DUPLICATE: TimeSeriesDuplicatePolicies.BLOCK
}), }),
['TS.ADD', 'key', '*', '1', 'ON_DUPLICATE', 'BLOCK'] ['TS.ADD', 'key', '*', '1', 'ON_DUPLICATE', 'BLOCK']
@@ -50,7 +50,7 @@ describe('ADD', () => {
it('with LABELS', () => { it('with LABELS', () => {
assert.deepEqual( assert.deepEqual(
transformArguments('key', '*', 1, { ADD.transformArguments('key', '*', 1, {
LABELS: { label: 'value' } LABELS: { label: 'value' }
}), }),
['TS.ADD', 'key', '*', '1', 'LABELS', 'label', 'value'] ['TS.ADD', 'key', '*', '1', 'LABELS', 'label', 'value']
@@ -59,7 +59,7 @@ describe('ADD', () => {
it('with RETENTION, ENCODING, CHUNK_SIZE, ON_DUPLICATE, LABELS', () => { it('with RETENTION, ENCODING, CHUNK_SIZE, ON_DUPLICATE, LABELS', () => {
assert.deepEqual( assert.deepEqual(
transformArguments('key', '*', 1, { ADD.transformArguments('key', '*', 1, {
RETENTION: 1, RETENTION: 1,
ENCODING: TimeSeriesEncoding.UNCOMPRESSED, ENCODING: TimeSeriesEncoding.UNCOMPRESSED,
CHUNK_SIZE: 1, CHUNK_SIZE: 1,

23
packages/time-series/lib/commands/ADD.ts
View File

@@ -1,3 +1,4 @@
import { RedisArgument, NumberReply, Command } from '@redis/client/dist/lib/RESP/types';
import { import {
transformTimestampArgument, transformTimestampArgument,
pushRetentionArgument, pushRetentionArgument,
@@ -7,10 +8,10 @@ import {
TimeSeriesDuplicatePolicies, TimeSeriesDuplicatePolicies,
Labels, Labels,
pushLabelsArgument, pushLabelsArgument,
Timestamp, Timestamp
} from '.'; } from '.';
interface AddOptions { export interface TsAddOptions {
RETENTION?: number; RETENTION?: number;
ENCODING?: TimeSeriesEncoding; ENCODING?: TimeSeriesEncoding;
CHUNK_SIZE?: number; CHUNK_SIZE?: number;
@@ -18,9 +19,15 @@ interface AddOptions {
LABELS?: Labels; LABELS?: Labels;
} }
export const FIRST_KEY_INDEX = 1; export default {
FIRST_KEY_INDEX: 1,
export function transformArguments(key: string, timestamp: Timestamp, value: number, options?: AddOptions): Array<string> { IS_READ_ONLY: false,
transformArguments(
key: RedisArgument,
timestamp: Timestamp,
value: number,
options?: TsAddOptions
) {
const args = [ const args = [
'TS.ADD', 'TS.ADD',
key, key,
@@ -41,6 +48,6 @@ export function transformArguments(key: string, timestamp: Timestamp, value: num
pushLabelsArgument(args, options?.LABELS); pushLabelsArgument(args, options?.LABELS);
return args; return args;
} },
transformReply: undefined as unknown as () => NumberReply
export declare function transformReply(): number; } as const satisfies Command;