redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-06 02:15:48 +03:00
Code Activity

Fix bug with optional callbacks for hmset.

Browse Source
This commit is contained in:
Matt Ranney
2011-06-30 16:13:57 -06:00
parent 04b4db8723
commit 891529c06a
4 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
changelog.md
View File

@@ -1,6 +1,10 @@
Changelog Changelog
========= =========
## v0.6.4 - June 30, 2011
Fix bug with optional callbacks for hmset.
## v0.6.2 - June 30, 2011 ## v0.6.2 - June 30, 2011
Bugs fixed: Bugs fixed:

2
index.js
View File

@@ -486,7 +486,7 @@ RedisClient.prototype.send_command = function (command, args, callback) {
// probably the fastest way: // probably the fastest way:
// client.command([arg1, arg2], cb); (straight passthrough) // client.command([arg1, arg2], cb); (straight passthrough)
// send_command(command, [arg1, arg2], cb); // send_command(command, [arg1, arg2], cb);
} else if (typeof callback === "undefined") { } else if (! callback) {
// most people find this variable argument length form more convenient, but it uses arguments, which is slower // most people find this variable argument length form more convenient, but it uses arguments, which is slower
// client.command(arg1, arg2, cb); (wraps up arguments into an array) // client.command(arg1, arg2, cb); (wraps up arguments into an array)
// send_command(command, [arg1, arg2, cb]); // send_command(command, [arg1, arg2, cb]);

2
package.json
View File

@@ -1,5 +1,5 @@
{ "name" : "redis", { "name" : "redis",
"version" : "0.6.2", "version" : "0.6.4",
"description" : "Redis client library", "description" : "Redis client library",
"author": "Matt Ranney <mjr@ranney.com>", "author": "Matt Ranney <mjr@ranney.com>",
"contributors": [ "contributors": [

2
test.js
View File

@@ -395,6 +395,8 @@ tests.HMSET_BUFFER_AND_ARRAY = function () {
client.HMSET(key, field1, value1, field2, value2, last(name, require_string("OK", name))); client.HMSET(key, field1, value1, field2, value2, last(name, require_string("OK", name)));
}; };
// TODO - add test for HMSET. It is special. Test for all forms as well as optional callbacks
tests.HMGET = function () { tests.HMGET = function () {
var key1 = "test hash 1", key2 = "test hash 2", name = "HMGET"; var key1 = "test hash 1", key2 = "test hash 2", name = "HMGET";