some cleanups

packages/client/index.ts

@@ -17,8 +17,7 @@ export { RedisClusterType, RedisClusterOptions };
 export const createCluster = RedisCluster.create;
 
 import RedisSentinel from './lib/sentinel';
-import { RedisSentinelOptions, RedisSentinelType } from './lib/sentinel/types';
-export { RedisSentinelType, RedisSentinelOptions };
+export { RedisSentinelOptions, RedisSentinelType } from './lib/sentinel/types';
 export const createSentinel = RedisSentinel.create;
 
 // export { GeoReplyWith } from './lib/commands/generic-transformers';

packages/client/lib/client/index.ts

@@ -460,7 +460,9 @@ export default class RedisClient<
       })
       .on('reconnecting', () => this.emit('reconnecting'))
       .on('drain', () => this.#maybeScheduleWrite())
-      .on('end', () => this.emit('end'));
+      .on('end', () => {
+        console.log('socket on end, emitting end', this.emit('end'));
+      });
   }
 
   #pingTimer?: NodeJS.Timeout;

packages/client/lib/sentinel/index.spec.ts

@@ -88,7 +88,7 @@ async function steadyState(frame: SentinelFramework) {
 }
 
 ["redis-sentinel-test-password", undefined].forEach(function (password) {
-  describe.only(`Sentinel - password = ${password}`, () => {
+  describe.skip(`Sentinel - password = ${password}`, () => {
     const config: RedisSentinelConfig = { sentinelName: "test", numberOfNodes: 3, password: password };
     const frame = new SentinelFramework(config);
     let tracer = new Array<string>();

packages/client/lib/sentinel/module.ts

@@ -1,4 +1,5 @@
-import { RedisModules } from '@redis/client';
+
+import { RedisModules } from '../RESP/types';
 import sentinel from './commands';
 
 export default {

packages/client/package.json

@@ -16,11 +16,11 @@
   },
   "devDependencies": {
     "@redis/test-utils": "*",
-    "@types/sinon": "^17.0.2",
+    "@types/sinon": "^17.0.3",
     "sinon": "^17.0.1"
   },
   "engines": {
-    "node": ">=14"
+    "node": ">= 18"
   },
   "repository": {
     "type": "git",