redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-07 13:22:56 +03:00
Code Activity

fix #1801

Browse Source
This commit is contained in:
leibale
2021-12-29 14:28:22 -05:00
parent 611e4100c8
commit 74daee3023
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/client/lib/client/index.spec.ts
View File

@@ -721,8 +721,6 @@ describe('Client', () => {
}); });
testUtils.testWithClient('client.disconnect', async client => { testUtils.testWithClient('client.disconnect', async client => {
await client.connect();
const pingPromise = client.ping(), const pingPromise = client.ping(),
disconnectPromise = client.disconnect(); disconnectPromise = client.disconnect();
assert.equal(client.isOpen, false); assert.equal(client.isOpen, false);
@@ -731,8 +729,10 @@ describe('Client', () => {
assert.doesNotReject(disconnectPromise), assert.doesNotReject(disconnectPromise),
assert.rejects(client.ping(), ClientClosedError) assert.rejects(client.ping(), ClientClosedError)
]); ]);
}, { }, GLOBAL.SERVERS.OPEN);
...GLOBAL.SERVERS.OPEN,
disableClientSetup: true testUtils.testWithClient('should be able to connect after disconnect (see #1801)', async client => {
}); await client.disconnect();
await client.connect();
}, GLOBAL.SERVERS.OPEN);
}); });

2
packages/client/lib/client/socket.ts
View File

@@ -170,7 +170,7 @@ export default class RedisSocket extends EventEmitter {
.off('error', reject) .off('error', reject)
.once('error', (err: Error) => this.#onSocketError(err)) .once('error', (err: Error) => this.#onSocketError(err))
.once('close', hadError => { .once('close', hadError => {
if (!hadError && this.#isOpen) { if (!hadError && this.#isOpen && this.#socket === socket) {
this.#onSocketError(new SocketClosedUnexpectedlyError()); this.#onSocketError(new SocketClosedUnexpectedlyError());
} }
}) })