fix SMOVE

docs/v4-to-v5.md

@@ -85,6 +85,7 @@ Some command arguments/replies have changed to align more closely to data types
 - `SCRIPT EXISTS`: `Array<boolean>` -> `Array<number>` [^boolean-to-number]
 - `SISMEMBER`: `boolean` -> `number` [^boolean-to-number]
 - `SMISMEMBER`: `Array<boolean>` -> `Array<number>` [^boolean-to-number]
+- `SMOVE`: `boolean` -> `number` [^boolean-to-number]
 
 [^enum-to-constants]: TODO
 

packages/client/lib/commands/SMOVE.spec.ts

@@ -1,19 +1,22 @@
-// import { strict as assert } from 'assert';
+import { strict as assert } from 'assert';
-// import testUtils, { GLOBAL } from '../test-utils';
+import testUtils, { GLOBAL } from '../test-utils';
-// import { transformArguments } from './SMOVE';
+import SMOVE from './SMOVE';
 
-// describe('SMOVE', () => {
+describe('SMOVE', () => {
-//     it('transformArguments', () => {
+  it('transformArguments', () => {
-//         assert.deepEqual(
+    assert.deepEqual(
-//             transformArguments('source', 'destination', 'member'),
+      SMOVE.transformArguments('source', 'destination', 'member'),
-//             ['SMOVE', 'source', 'destination', 'member']
+      ['SMOVE', 'source', 'destination', 'member']
-//         );
+    );
-//     });
+  });
 
-//     testUtils.testWithClient('client.sMove', async client => {
+  testUtils.testAll('sMove', async client => {
-//         assert.equal(
+    assert.equal(
-//             await client.sMove('source', 'destination', 'member'),
+      await client.sMove('{tag}source', '{tag}destination', 'member'),
-//             false
+      0
-//         );
+    );
-//     }, GLOBAL.SERVERS.OPEN);
+  }, {
-// });
+    client: GLOBAL.SERVERS.OPEN,
+    cluster: GLOBAL.CLUSTERS.OPEN
+  });
+});

packages/client/lib/commands/SMOVE.ts

@@ -1,13 +1,14 @@
-// import { RedisCommandArgument, RedisCommandArguments } from '.';
+import { RedisArgument, NumberReply, Command } from '../RESP/types';
 
-// export const FIRST_KEY_INDEX = 1;
+export default {
-
+  FIRST_KEY_INDEX: 1,
-// export function transformArguments(
+  IS_READ_ONLY: false,
-//     source: RedisCommandArgument,
+  transformArguments(
-//     destination: RedisCommandArgument,
+    source: RedisArgument,
-//     member: RedisCommandArgument
+    destination: RedisArgument,
-// ): RedisCommandArguments {
+    member: RedisArgument
-//     return ['SMOVE', source, destination, member];
+  ) {
-// }
+    return ['SMOVE', source, destination, member];
-
+  },
-// export { transformBooleanReply as transformReply } from './generic-transformers';
+  transformReply: undefined as unknown as () => NumberReply
+} as const satisfies Command;

packages/client/lib/commands/index.ts

@@ -139,6 +139,7 @@ import SINTERSTORE from './SINTERSTORE';
 import SISMEMBER from './SISMEMBER';
 import SMEMBERS from './SMEMBERS';
 import SMISMEMBER from './SMISMEMBER';
+import SMOVE from './SMOVE';
 import SORT_RO from './SORT_RO';
 import SORT_STORE from './SORT_STORE';
 import SORT from './SORT';
@@ -479,6 +480,8 @@ export default {
   sMembers: SMEMBERS,
   SMISMEMBER,
   smIsMember: SMISMEMBER,
+  SMOVE,
+  sMove: SMOVE,
   SORT_RO,
   sortRo: SORT_RO,
   SORT_STORE,

todo.md

@@ -11,7 +11,6 @@
 
 
 # waiting List categoreis
-- List
 - Set
 - Bitmap