redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-06 02:15:48 +03:00
Code Activity

fix cluster.sUnsubscribe - make listener optional

Browse Source
This commit is contained in:
Clubsandwich
2023-11-21 03:40:38 +09:00
committed by GitHub
parent e91509a3e1
commit 623b56b5ca
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
packages/client/lib/cluster/index.ts
View File

@@ -20,12 +20,12 @@ export interface RedisClusterOptions<
S extends RedisScripts = Record<string, never> S extends RedisScripts = Record<string, never>
> extends RedisExtensions<M, F, S> { > extends RedisExtensions<M, F, S> {
/** /**
* Should contain details for some of the cluster nodes that the client will use to discover * Should contain details for some of the cluster nodes that the client will use to discover
* the "cluster topology". We recommend including details for at least 3 nodes here. * the "cluster topology". We recommend including details for at least 3 nodes here.
*/ */
rootNodes: Array<RedisClusterClientOptions>; rootNodes: Array<RedisClusterClientOptions>;
/** /**
* Default values used for every client in the cluster. Use this to specify global values, * Default values used for every client in the cluster. Use this to specify global values,
* for example: ACL credentials, timeouts, TLS configuration etc. * for example: ACL credentials, timeouts, TLS configuration etc.
*/ */
defaults?: Partial<RedisClusterClientOptions>; defaults?: Partial<RedisClusterClientOptions>;
@@ -45,7 +45,7 @@ export interface RedisClusterOptions<
/** /**
* Mapping between the addresses in the cluster (see `CLUSTER SHARDS`) and the addresses the client should connect to * Mapping between the addresses in the cluster (see `CLUSTER SHARDS`) and the addresses the client should connect to
* Useful when the cluster is running on another network * Useful when the cluster is running on another network
* *
*/ */
nodeAddressMap?: NodeAddressMap; nodeAddressMap?: NodeAddressMap;
} }
@@ -98,7 +98,7 @@ export default class RedisCluster<
readonly #options: RedisClusterOptions<M, F, S>; readonly #options: RedisClusterOptions<M, F, S>;
readonly #slots: RedisClusterSlots<M, F, S>; readonly #slots: RedisClusterSlots<M, F, S>;
get slots() { get slots() {
return this.#slots.slots; return this.#slots.slots;
} }
@@ -310,7 +310,7 @@ export default class RedisCluster<
listener?: PubSubListener<boolean>, listener?: PubSubListener<boolean>,
bufferMode?: T bufferMode?: T
) { ) {
return this.#slots.executeUnsubscribeCommand(client => return this.#slots.executeUnsubscribeCommand(client =>
client.UNSUBSCRIBE(channels, listener, bufferMode) client.UNSUBSCRIBE(channels, listener, bufferMode)
); );
} }
@@ -333,7 +333,7 @@ export default class RedisCluster<
listener?: PubSubListener<T>, listener?: PubSubListener<T>,
bufferMode?: T bufferMode?: T
) { ) {
return this.#slots.executeUnsubscribeCommand(client => return this.#slots.executeUnsubscribeCommand(client =>
client.PUNSUBSCRIBE(patterns, listener, bufferMode) client.PUNSUBSCRIBE(patterns, listener, bufferMode)
); );
} }
@@ -344,7 +344,7 @@ export default class RedisCluster<
channels: string | Array<string>, channels: string | Array<string>,
listener: PubSubListener<T>, listener: PubSubListener<T>,
bufferMode?: T bufferMode?: T
) { ) {
const maxCommandRedirections = this.#options.maxCommandRedirections ?? 16, const maxCommandRedirections = this.#options.maxCommandRedirections ?? 16,
firstChannel = Array.isArray(channels) ? channels[0] : channels; firstChannel = Array.isArray(channels) ? channels[0] : channels;
let client = await this.#slots.getShardedPubSubClient(firstChannel); let client = await this.#slots.getShardedPubSubClient(firstChannel);
@@ -371,7 +371,7 @@ export default class RedisCluster<
SUNSUBSCRIBE<T extends boolean = false>( SUNSUBSCRIBE<T extends boolean = false>(
channels: string | Array<string>, channels: string | Array<string>,
listener: PubSubListener<T>, listener?: PubSubListener<T>,
bufferMode?: T bufferMode?: T
) { ) {
return this.#slots.executeShardedUnsubscribeCommand( return this.#slots.executeShardedUnsubscribeCommand(
@@ -391,7 +391,7 @@ export default class RedisCluster<
} }
nodeClient(node: ShardNode<M, F, S>) { nodeClient(node: ShardNode<M, F, S>) {
return this.#slots.nodeClient(node); return this.#slots.nodeClient(node);
} }
getRandomNode() { getRandomNode() {