redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-07 13:22:56 +03:00
Code Activity

Fix multi regression. Closes #889

Browse Source 
Allow commands being executed after a Multi / Batch was initiated but not yet executed
This commit is contained in:
Ruben Bridgewater
2015-10-14 00:58:27 +02:00
parent 28d343c2ad
commit 60e9d0fdd6
3 changed files with 54 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
test/commands/multi.spec.js
View File

@@ -73,6 +73,47 @@ describe("The 'multi' method", function () {
assert.strictEqual(notBuffering, true);
});
it("runs normal calls inbetween multis", function (done) {
var multi1 = client.multi();
multi1.set("m1", "123");
client.set('m2', '456', done);
});
it("runs simultaneous multis with the same client", function (done) {
var end = helper.callFuncAfter(done, 2);
var multi1 = client.multi();
multi1.set("m1", "123");
multi1.get('m1');
var multi2 = client.multi();
multi2.set("m2", "456");
multi2.get('m2');
multi1.exec(end);
multi2.exec(function(err, res) {
assert.strictEqual(res[1], '456');
end();
});
});
it("runs simultaneous multis with the same client version 2", function (done) {
var end = helper.callFuncAfter(done, 2);
var multi2 = client.multi();
var multi1 = client.multi();
multi2.set("m2", "456");
multi1.set("m1", "123");
multi1.get('m1');
multi2.get('m2');
multi1.exec(end);
multi2.exec(function(err, res) {
assert.strictEqual(res[1], '456');
end();
});
});
it('roles back a transaction when one command in a sequence of commands fails', function (done) {
var multi1, multi2;
var expected = helper.serverVersionAtLeast(client, [2, 6, 5]) ? helper.isError() : function () {};