redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-06 02:15:48 +03:00
Code Activity

fixed up our one commented out test, based on @erinspice's code review

Browse Source
This commit is contained in:
Benjamin Coe
2015-08-15 13:25:03 -07:00
parent 51b1ba2bef
commit 5d83e64d00
1 changed files with 10 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
test/node_redis.spec.js
View File

@@ -84,27 +84,22 @@ describe("The node_redis client", function () {
}); });
}); });
// TODO: we should only have a single subscription in this this
// test but unsubscribing from the single channel indicates
// that one subscriber still exists, let's dig into this.
describe("and it's subscribed to a channel", function () { describe("and it's subscribed to a channel", function () {
// reconnect_select_db_after_pubsub // reconnect_select_db_after_pubsub
// Does not pass. // Does not pass.
// "Connection in subscriber mode, only subscriber commands may be used" // "Connection in subscriber mode, only subscriber commands may be used"
xit("reconnects, unsubscribes, and can retrieve the pre-existing data", function (done) { it("reconnects, unsubscribes, and can retrieve the pre-existing data", function (done) {
client.on("reconnecting", function on_recon(params) { client.on("reconnecting", function on_recon(params) {
client.on("ready", function on_connect() { client.on("ready", function on_connect() {
async.parallel([function (cb) { client.unsubscribe(helper.isNotError());
client.unsubscribe("recon channel", function (err, res) {
helper.isNotError()(err, res); client.on('unsubscribe', function (channel, count) {
cb(); // we should now be out of subscriber mode.
}); client.set('foo', 'bar', helper.isNumber(1));
}, function (cb) { return done();
client.get("recon 1", function (err, res) {
helper.isString("one")(err, res);
cb();
});
}], function (err, results) {
client.removeListener("connect", on_connect);
client.removeListener("reconnecting", on_recon);
done(err);
}); });
}); });
}); });