From 59e2e6d626124e4b4be4d682b0046b4c6b23461a Mon Sep 17 00:00:00 2001
From: dovi <dovi.rivkin@gmail.com>
Date: Wed, 5 Jul 2023 14:18:03 -0400
Subject: [PATCH] fix ALTER

---
 .../time-series/lib/commands/ALTER.spec.ts    | 128 +++++++++---------
 packages/time-series/lib/commands/ALTER.ts    |  24 ++--
 2 files changed, 77 insertions(+), 75 deletions(-)

diff --git a/packages/time-series/lib/commands/ALTER.spec.ts b/packages/time-series/lib/commands/ALTER.spec.ts
index cd066533aa..0a7d7cb2ca 100644
--- a/packages/time-series/lib/commands/ALTER.spec.ts
+++ b/packages/time-series/lib/commands/ALTER.spec.ts
@@ -1,72 +1,72 @@
 import { strict as assert } from 'assert';
 import { TimeSeriesDuplicatePolicies } from '.';
 import testUtils, { GLOBAL } from '../test-utils';
-import { transformArguments } from './ALTER';
+import ALTER from './ALTER';
 
-describe('ALTER', () => {
-    describe('transformArguments', () => {
-        it('without options', () => {
-            assert.deepEqual(
-                transformArguments('key'),
-                ['TS.ALTER', 'key']
-            );
-        });
-
-        it('with RETENTION', () => {
-            assert.deepEqual(
-                transformArguments('key', {
-                    RETENTION: 1
-                }),
-                ['TS.ALTER', 'key', 'RETENTION', '1']
-            );
-        });
-
-        it('with CHUNK_SIZE', () => {
-            assert.deepEqual(
-                transformArguments('key', {
-                    CHUNK_SIZE: 1
-                }),
-                ['TS.ALTER', 'key', 'CHUNK_SIZE', '1']
-            );
-        });
-
-        it('with DUPLICATE_POLICY', () => {
-            assert.deepEqual(
-                transformArguments('key', {
-                    DUPLICATE_POLICY: TimeSeriesDuplicatePolicies.BLOCK
-                }),
-                ['TS.ALTER', 'key', 'DUPLICATE_POLICY', 'BLOCK']
-            );
-        });
-
-        it('with LABELS', () => {
-            assert.deepEqual(
-                transformArguments('key', {
-                    LABELS: { label: 'value' }
-                }),
-                ['TS.ALTER', 'key', 'LABELS', 'label', 'value']
-            );
-        });
-
-        it('with RETENTION, CHUNK_SIZE, DUPLICATE_POLICY, LABELS', () => {
-            assert.deepEqual(
-                transformArguments('key', {
-                    RETENTION: 1,
-                    CHUNK_SIZE: 1,
-                    DUPLICATE_POLICY: TimeSeriesDuplicatePolicies.BLOCK,
-                    LABELS: { label: 'value' }
-                }),
-                ['TS.ALTER', 'key', 'RETENTION', '1', 'CHUNK_SIZE', '1', 'DUPLICATE_POLICY', 'BLOCK', 'LABELS', 'label', 'value']
-            );
-        });
+describe('TS.ALTER', () => {
+  describe('transformArguments', () => {
+    it('without options', () => {
+      assert.deepEqual(
+        ALTER.transformArguments('key'),
+        ['TS.ALTER', 'key']
+      );
     });
 
-    testUtils.testWithClient('client.ts.alter', async client => {
-        await client.ts.create('key');
+    it('with RETENTION', () => {
+      assert.deepEqual(
+        ALTER.transformArguments('key', {
+          RETENTION: 1
+        }),
+        ['TS.ALTER', 'key', 'RETENTION', '1']
+      );
+    });
 
-        assert.equal(
-            await client.ts.alter('key', { RETENTION: 1 }),
-            'OK'
-        );
-    }, GLOBAL.SERVERS.OPEN);
+    it('with CHUNK_SIZE', () => {
+      assert.deepEqual(
+        ALTER.transformArguments('key', {
+          CHUNK_SIZE: 1
+        }),
+        ['TS.ALTER', 'key', 'CHUNK_SIZE', '1']
+      );
+    });
+
+    it('with DUPLICATE_POLICY', () => {
+      assert.deepEqual(
+        ALTER.transformArguments('key', {
+          DUPLICATE_POLICY: TimeSeriesDuplicatePolicies.BLOCK
+        }),
+        ['TS.ALTER', 'key', 'DUPLICATE_POLICY', 'BLOCK']
+      );
+    });
+
+    it('with LABELS', () => {
+      assert.deepEqual(
+        ALTER.transformArguments('key', {
+          LABELS: { label: 'value' }
+        }),
+        ['TS.ALTER', 'key', 'LABELS', 'label', 'value']
+      );
+    });
+
+    it('with RETENTION, CHUNK_SIZE, DUPLICATE_POLICY, LABELS', () => {
+      assert.deepEqual(
+        ALTER.transformArguments('key', {
+          RETENTION: 1,
+          CHUNK_SIZE: 1,
+          DUPLICATE_POLICY: TimeSeriesDuplicatePolicies.BLOCK,
+          LABELS: { label: 'value' }
+        }),
+        ['TS.ALTER', 'key', 'RETENTION', '1', 'CHUNK_SIZE', '1', 'DUPLICATE_POLICY', 'BLOCK', 'LABELS', 'label', 'value']
+      );
+    });
+  });
+
+  testUtils.testWithClient('client.ts.alter', async client => {
+    await client.ts.create('key');
+
+    assert.equal(
+      await client.ts.alter('key', { RETENTION: 1 }),
+      'OK'
+    );
+  }, GLOBAL.SERVERS.OPEN);
 });
diff --git a/packages/time-series/lib/commands/ALTER.ts b/packages/time-series/lib/commands/ALTER.ts
index 7b9e1e774c..bf4e4d528c 100644
--- a/packages/time-series/lib/commands/ALTER.ts
+++ b/packages/time-series/lib/commands/ALTER.ts
@@ -1,15 +1,17 @@
 import { pushRetentionArgument, Labels, pushLabelsArgument, TimeSeriesDuplicatePolicies, pushChunkSizeArgument, pushDuplicatePolicy } from '.';
+import { RedisArgument, SimpleStringReply, Command } from '@redis/client/dist/lib/RESP/types';
 
-export const FIRST_KEY_INDEX = 1;
-
-interface AlterOptions {
-    RETENTION?: number;
-    CHUNK_SIZE?: number;
-    DUPLICATE_POLICY?: TimeSeriesDuplicatePolicies;
-    LABELS?: Labels;
+export interface TsAlterOptions {
+  RETENTION?: number;
+  CHUNK_SIZE?: number;
+  DUPLICATE_POLICY?: TimeSeriesDuplicatePolicies;
+  LABELS?: Labels;
 }
 
-export function transformArguments(key: string, options?: AlterOptions): Array<string> {
+export default {
+  FIRST_KEY_INDEX: 1,
+  IS_READ_ONLY: false,
+  transformArguments(key: RedisArgument, options?: TsAlterOptions) {
     const args = ['TS.ALTER', key];
 
     pushRetentionArgument(args, options?.RETENTION);
@@ -21,6 +23,6 @@ export function transformArguments(key: string, options?: AlterOptions): Array<s
     pushLabelsArgument(args, options?.LABELS);
 
     return args;
-}
-
-export declare function transformReply(): 'OK';
+  },
+transformReply: undefined as unknown as () => SimpleStringReply<'OK'>
+} as const satisfies Command;