redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-07 13:22:56 +03:00
Code Activity

fix: silence auth errors on reconnect

Browse Source
This commit is contained in:
Ruben Bridgewater
2017-07-23 14:11:16 -03:00
parent 42e8bd607f
commit 4f7f1adf50
2 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
index.js
View File

@@ -228,8 +228,6 @@ function create_parser (self) {
RedisClient.prototype.create_stream = function () { RedisClient.prototype.create_stream = function () {
var self = this; var self = this;
var first_attempt = !this.stream;
// Init parser // Init parser
this.reply_parser = create_parser(this); this.reply_parser = create_parser(this);
@@ -308,8 +306,7 @@ RedisClient.prototype.create_stream = function () {
this.ready = true; this.ready = true;
// Fail silently as we might not be able to connect // Fail silently as we might not be able to connect
this.auth(this.auth_pass, function (err) { this.auth(this.auth_pass, function (err) {
if (err && first_attempt) { if (err && err.code !== 'UNCERTAIN_STATE') {
self.command_queue.get(0).callback = noop;
self.emit('error', err); self.emit('error', err);
} }
}); });

5
test/auth.spec.js
View File

@@ -260,10 +260,9 @@ describe('client authentication', function () {
password: 'wrong_password', password: 'wrong_password',
parser: parser parser: parser
}); });
client.on('error', function (err) { client.once('error', function (err) {
assert.strictEqual(err.message, 'ERR invalid password'); assert.strictEqual(err.message, 'ERR invalid password');
// Make sure no other errors are reported done();
setTimeout(done, 50);
}); });
}); });