redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-06 02:15:48 +03:00
Code Activity

Revert "hmset throws/errors out on non-string values. fixes #218"

Browse Source 
Reverting because this was a documentation problem, not a problem with
the code. Performance-wise, this is faster than the approach in #345, though
it may cause users more trouble. This is okay, if someone opens an issue we
can point them to the docs.

This reverts commit b60e001fa0.

Conflicts:

	index.js
	test.js
This commit is contained in:
DTrejo
2013-02-23 22:56:08 -05:00
parent a02b0f57e4
commit 405011b640
3 changed files with 1 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@@ -282,7 +282,7 @@ Output:
Multiple values in a hash can be set by supplying an object: Multiple values in a hash can be set by supplying an object:
client.HMSET(key2, { client.HMSET(key2, {
"0123456789": "abcdefghij", // NOTE: the key and value must both be strings "0123456789": "abcdefghij", // NOTE: key and value will be coerced to strings
"some manner of key": "a type of value" "some manner of key": "a type of value"
}); });

8
index.js
View File

@@ -957,14 +957,6 @@ RedisClient.prototype.hmset = function (args, callback) {
for (i = 0, il = tmp_keys.length; i < il ; i++) { for (i = 0, il = tmp_keys.length; i < il ; i++) {
key = tmp_keys[i]; key = tmp_keys[i];
tmp_args.push(key); tmp_args.push(key);
if (typeof args[1][key] !== "string") {
var err = new Error("hmset expected value to be a string", key, ":", args[1][key]);
if (callback) {
return callback(err);
} else {
throw err;
}
}
tmp_args.push(args[1][key]); tmp_args.push(args[1][key]);
} }
args = tmp_args; args = tmp_args;

18
test.js
View File

@@ -1616,24 +1616,6 @@ tests.OPTIONAL_CALLBACK_UNDEFINED = function () {
client.get("op_cb2", last(name, require_string("y", name))); client.get("op_cb2", last(name, require_string("y", name)));
}; };
tests.HMSET_THROWS_ON_NON_STRINGS = function () {
var name = "HMSET_THROWS_ON_NON_STRINGS";
var hash = name;
var data = { "a": [ "this is not a string" ] };
client.hmset(hash, data, cb);
function cb(e, r) {
assert(e); // should be an error!
}
// alternative way it throws
function thrower() {
client.hmset(hash, data);
}
assert.throws(thrower);
next(name);
};
tests.ENABLE_OFFLINE_QUEUE_TRUE = function () { tests.ENABLE_OFFLINE_QUEUE_TRUE = function () {
var name = "ENABLE_OFFLINE_QUEUE_TRUE"; var name = "ENABLE_OFFLINE_QUEUE_TRUE";
var cli = redis.createClient(9999, null, { var cli = redis.createClient(9999, null, {