redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-04 15:02:09 +03:00
Code Activity

Revert "hmset throws/errors out on non-string values. fixes #218"

Browse Source 
Reverting because this was a documentation problem, not a problem with
the code. Performance-wise, this is faster than the approach in #345, though
it may cause users more trouble. This is okay, if someone opens an issue we
can point them to the docs.

This reverts commit b60e001fa0.

Conflicts:

	index.js
	test.js
This commit is contained in:
DTrejo
2013-02-23 22:56:08 -05:00
parent a02b0f57e4
commit 405011b640
3 changed files with 1 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
index.js
View File

@@ -957,14 +957,6 @@ RedisClient.prototype.hmset = function (args, callback) {
for (i = 0, il = tmp_keys.length; i < il ; i++) {
key = tmp_keys[i];
tmp_args.push(key);
if (typeof args[1][key] !== "string") {
var err = new Error("hmset expected value to be a string", key, ":", args[1][key]);
if (callback) {
return callback(err);
} else {
throw err;
}
}
tmp_args.push(args[1][key]);
}
args = tmp_args;