redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-07 13:22:56 +03:00
Code Activity

Fix for [GH-127]

Browse Source 
Re-initialize the reply parser for every new connection.  If a connection is terminated,
the parser could be left in a bad state.  After the auto-reconnect magic kicks in, it
tries to reuse the old parser, which will not work.

This change is visible to client programs if you depend on client.reply_parser.name being
set immediately.  It will now only be set after a connection is established.

Thanks to @jhurliman for reporting and @pietern for the fix suggestion.
This commit is contained in:
Matt Ranney
2011-08-11 11:00:02 -07:00
parent 688b838be7
commit 3e95c55a03
4 changed files with 60 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
multi_bench.js
View File

@@ -58,11 +58,12 @@ function create_clients(callback) {
while (active_clients < num_clients) {
client = clients[active_clients++] = redis.createClient(6379, "127.0.0.1", client_options);
if (! parser_logged) {
console.log("Using reply parser " + client.reply_parser.name);
parser_logged = true;
}
client.on("connect", function () {
if (! parser_logged) {
console.log("Using reply parser " + client.reply_parser.name);
parser_logged = true;
}
// Fire callback when all clients are connected
connected += 1;
if (connected === num_clients) {