redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-06 02:15:48 +03:00
Code Activity

fix COPY spec

Browse Source
This commit is contained in:
dovi
2023-05-02 20:02:03 -04:00
parent ca90d51fb8
commit 3dfea00318
3 changed files with 48 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
packages/client/lib/commands/COPY.spec.ts
View File

@@ -1,6 +1,6 @@
import { strict as assert } from 'assert'; import { strict as assert } from 'assert';
import testUtils, { GLOBAL } from '../test-utils'; import testUtils, { GLOBAL } from '../test-utils';
import { transformArguments, transformReply } from './COPY'; import COPY from './COPY';
describe('COPY', () => { describe('COPY', () => {
testUtils.isVersionGreaterThanHook([6, 2]); testUtils.isVersionGreaterThanHook([6, 2]);
@@ -8,15 +8,15 @@ describe('COPY', () => {
describe('transformArguments', () => { describe('transformArguments', () => {
it('simple', () => { it('simple', () => {
assert.deepEqual( assert.deepEqual(
transformArguments('source', 'destination'), COPY.transformArguments('source', 'destination'),
['COPY', 'source', 'destination'] ['COPY', 'source', 'destination']
); );
}); });
it('with destination DB flag', () => { it('with destination DB flag', () => {
assert.deepEqual( assert.deepEqual(
transformArguments('source', 'destination', { COPY.transformArguments('source', 'destination', {
destinationDb: 1 DB: 1
}), }),
['COPY', 'source', 'destination', 'DB', '1'] ['COPY', 'source', 'destination', 'DB', '1']
); );
@@ -24,8 +24,8 @@ describe('COPY', () => {
it('with replace flag', () => { it('with replace flag', () => {
assert.deepEqual( assert.deepEqual(
transformArguments('source', 'destination', { COPY.transformArguments('source', 'destination', {
replace: true REPLACE: true
}), }),
['COPY', 'source', 'destination', 'REPLACE'] ['COPY', 'source', 'destination', 'REPLACE']
); );
@@ -33,35 +33,22 @@ describe('COPY', () => {
it('with both flags', () => { it('with both flags', () => {
assert.deepEqual( assert.deepEqual(
transformArguments('source', 'destination', { COPY.transformArguments('source', 'destination', {
destinationDb: 1, DB: 1,
replace: true REPLACE: true
}), }),
['COPY', 'source', 'destination', 'DB', '1', 'REPLACE'] ['COPY', 'source', 'destination', 'DB', '1', 'REPLACE']
); );
}); });
}); });
describe('transformReply', () => { testUtils.testAll('copy', async client => {
it('0', () => {
assert.equal( assert.equal(
transformReply(0), await client.copy('{tag}source', '{tag}destination'),
false false
); );
}, {
client: GLOBAL.SERVERS.OPEN,
cluster: GLOBAL.CLUSTERS.OPEN
}); });
it('1', () => {
assert.equal(
transformReply(1),
true
);
});
});
testUtils.testWithClient('client.copy', async client => {
assert.equal(
await client.copy('source', 'destination'),
false
);
}, GLOBAL.SERVERS.OPEN);
}); });

1
packages/client/lib/commands/COPY.ts
View File

@@ -7,6 +7,7 @@ export interface CopyCommandOptions {
export default { export default {
FIRST_KEY_INDEX: 1, FIRST_KEY_INDEX: 1,
IS_READ_ONLY: false,
transformArguments(source: RedisArgument, destination: RedisArgument, options?: CopyCommandOptions) { transformArguments(source: RedisArgument, destination: RedisArgument, options?: CopyCommandOptions) {
const args = ['COPY', source, destination]; const args = ['COPY', source, destination];

3
packages/client/lib/commands/index.ts
View File

@@ -40,6 +40,7 @@ import CLUSTER_SLOTS from './CLUSTER_SLOTS';
import CLUSTER_MEET from './CLUSTER_MEET'; import CLUSTER_MEET from './CLUSTER_MEET';
import CLUSTER_MYID from './CLUSTER_MYID'; import CLUSTER_MYID from './CLUSTER_MYID';
import CLUSTER_REPLICATE from './CLUSTER_REPLICATE'; import CLUSTER_REPLICATE from './CLUSTER_REPLICATE';
import COPY from './COPY';
import DECR from './DECR'; import DECR from './DECR';
import DECRBY from './DECRBY'; import DECRBY from './DECRBY';
import DEL from './DEL'; import DEL from './DEL';
@@ -267,6 +268,8 @@ export default {
clusterMyId: CLUSTER_MYID, clusterMyId: CLUSTER_MYID,
CLUSTER_REPLICATE, CLUSTER_REPLICATE,
clusterReplicate: CLUSTER_REPLICATE, clusterReplicate: CLUSTER_REPLICATE,
COPY,
copy: COPY,
DECR, DECR,
decr: DECR, decr: DECR,
DECRBY, DECRBY,