redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-07 13:22:56 +03:00
Code Activity

Use instanceof Array instead of Array.isArray

Browse Source 
The reply is being done with a regular array and therefor will be the same array instance
This commit is contained in:
Ruben Bridgewater
2016-01-21 22:38:05 +01:00
parent fb0eaf4d41
commit 32172cd291
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
index.js
View File

@@ -535,8 +535,6 @@ RedisClient.prototype.drain = function () {
RedisClient.prototype.emit_idle = function (queue_len) { RedisClient.prototype.emit_idle = function (queue_len) {
if (this.pub_sub_mode === false && queue_len === 0) { if (this.pub_sub_mode === false && queue_len === 0) {
// Free the queue capacity memory by using a new queue
this.command_queue = new Queue();
this.emit('idle'); this.emit('idle');
} }
}; };
@@ -547,7 +545,7 @@ RedisClient.prototype.return_reply = function (reply) {
// If the 'reply' here is actually a message received asynchronously due to a // If the 'reply' here is actually a message received asynchronously due to a
// pubsub subscription, don't pop the command queue as we'll only be consuming // pubsub subscription, don't pop the command queue as we'll only be consuming
// the head command prematurely. // the head command prematurely.
if (this.pub_sub_mode && Array.isArray(reply) && reply[0]) { if (this.pub_sub_mode && reply instanceof Array && reply[0]) {
type = reply[0].toString(); type = reply[0].toString();
} }
@@ -571,12 +569,13 @@ RedisClient.prototype.return_reply = function (reply) {
debug('No callback for reply'); debug('No callback for reply');
} }
} else if (this.pub_sub_mode || command_obj && command_obj.sub_command) { } else if (this.pub_sub_mode || command_obj && command_obj.sub_command) {
if (Array.isArray(reply)) { if (reply instanceof Array) {
if ((!command_obj || command_obj.buffer_args === false) && !this.options.return_buffers) { if ((!command_obj || command_obj.buffer_args === false) && !this.options.return_buffers) {
reply = utils.reply_to_strings(reply); reply = utils.reply_to_strings(reply);
} }
type = reply[0].toString(); type = reply[0].toString();
// TODO: Add buffer emiters (we have to get all pubsub messages as buffers back in that case)
if (type === 'message') { if (type === 'message') {
this.emit('message', reply[1], reply[2]); // channel, message this.emit('message', reply[1], reply[2]); // channel, message
} else if (type === 'pmessage') { } else if (type === 'pmessage') {