redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-07 13:22:56 +03:00
Code Activity

Fix individual createClient functions passing undefined options to a new instance. Closes #893

Browse Source
This commit is contained in:
Ruben Bridgewater
2015-10-18 16:58:34 +02:00
parent ce4a67bb74
commit 304abe4318
3 changed files with 18 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
test/connection.spec.js
View File

@@ -4,6 +4,7 @@ var assert = require("assert");
var config = require("./lib/config");
var helper = require('./helper');
var redis = config.redis;
var net = require('net');
describe("connection tests", function () {
helper.allTests(function(parser, ip, args) {
@@ -186,27 +187,16 @@ describe("connection tests", function () {
});
});
it("buffer commands and flush them after ", function (done) {
client = redis.createClient(9999, null, {
parser: parser
});
client.on('error', function(e) {
// ignore, b/c expecting a "can't connect" error
});
return setTimeout(function() {
client.set('foo', 'bar', function(err, result) {
// This should never be called
return done(err);
});
return setTimeout(function() {
assert.strictEqual(client.offline_queue.length, 1);
return done();
}, 25);
}, 50);
});
it("works with missing options object for new redis instances", function () {
// This is needed for libraries that have their own createClient function like fakeredis
var cnxOptions = {
port : 6379,
host : '127.0.0.1',
family : ip === 'IPv6' ? 6 : 4
};
var net_client = net.createConnection(cnxOptions);
client = new redis.RedisClient(net_client);
});
it("throws on strange connection info", function () {
try {