Fix some minor issues and add more tests

Do not mutate the options object and add some more tests

test/parser.spec.js

@@ -0,0 +1,113 @@
+'use strict';
+
+var assert = require('assert');
+var config = require("./lib/config");
+var utils = require("../lib/utils");
+var redis = config.redis;
+var parsers = [
+    require("../lib/parsers/javascript").Parser
+];
+try {
+    // Test the hiredis parser if available
+    parsers.push(require("../lib/parsers/hiredis").Parser);
+} catch (e) {}
+
+describe('parsers', function () {
+
+    parsers.forEach(function (Parser) {
+
+        describe(Parser.name, function () {
+
+            it('handles multi-bulk reply', function (done) {
+                var parser = new Parser();
+                var reply_count = 0;
+                function check_reply(reply) {
+                    reply = utils.reply_to_strings(reply);
+                    assert.deepEqual(reply, [['a']], "Expecting multi-bulk reply of [['a']]");
+                    reply_count++;
+                }
+                parser.send_reply = check_reply;
+
+                parser.execute(new Buffer('*1\r\n*1\r\n$1\r\na\r\n'));
+
+                parser.execute(new Buffer('*1\r\n*1\r'));
+                parser.execute(new Buffer('\n$1\r\na\r\n'));
+
+                parser.execute(new Buffer('*1\r\n*1\r\n'));
+                parser.execute(new Buffer('$1\r\na\r\n'));
+
+                assert.equal(reply_count, 3, "check reply should have been called three times");
+                return done();
+            });
+
+            it('parser error', function (done) {
+                var parser = new Parser();
+                var reply_count = 0;
+                function check_reply(reply) {
+                    assert.strictEqual(reply.message, 'Protocol error, got "a" as reply type byte');
+                    reply_count++;
+                }
+                parser.send_error = check_reply;
+
+                parser.execute(new Buffer('a*1\r*1\r$1`zasd\r\na'));
+
+                assert.equal(reply_count, 1, "check reply should have been called one time");
+                return done();
+            });
+
+            it('line breaks in the beginning', function (done) {
+                var parser = new Parser();
+                var reply_count = 0;
+                function check_reply(reply) {
+                    reply = utils.reply_to_strings(reply);
+                    assert.deepEqual(reply, [['a']], "Expecting multi-bulk reply of [['a']]");
+                    reply_count++;
+                }
+                parser.send_reply = check_reply;
+
+                parser.execute(new Buffer('*1\r\n*1\r\n$1\r\na'));
+
+                parser.execute(new Buffer('\r\n*1\r\n*1\r'));
+                parser.execute(new Buffer('\n$1\r\na\r\n'));
+
+                parser.execute(new Buffer('*1\r\n*1\r\n'));
+                parser.execute(new Buffer('$1\r\na\r\n'));
+
+                assert.equal(reply_count, 3, "check reply should have been called three times");
+                return done();
+            });
+        });
+    });
+
+    // Activate this if you want to fry your cpu / memory
+    describe.skip("test out of memory", function () {
+        var args = config.configureClient('javascript', '127.0.0.1');
+        var clients = new Array(300).join(" ").split(" ");
+        var client;
+        beforeEach(function (done) {
+            client = redis.createClient.apply(redis.createClient, args);
+            client.once("connect", function () {
+                client.flushdb(done);
+            });
+        });
+
+        it('reach limit and wait for further data', function (done) {
+            setTimeout(done, 5000);
+            clients.forEach(function(entry, a) {
+                var max = 0;
+                var client = redis.createClient.apply(redis.createClient, args);
+                client.on('ready', function() {
+                    while (++max < 50) {
+                        var item = [];
+                        for (var i = 0; i < 100; ++i) {
+                            item.push('aaa' + (Math.random() * 1000000 | 0));
+                        }
+                        client.del('foo' + a);
+                        client.lpush('foo' + a, item);
+                        client.lrange('foo' + a, 0, 99);
+                    }
+                });
+            });
+        });
+    });
+});