fix ZRANGEBYSCORE

packages/client/lib/commands/ZRANGEBYSCORE.spec.ts

@@ -1,33 +1,36 @@
-// import { strict as assert } from 'assert';
+import { strict as assert } from 'assert';
-// import testUtils, { GLOBAL } from '../test-utils';
+import testUtils, { GLOBAL } from '../test-utils';
-// import { transformArguments } from './ZRANGEBYSCORE';
+import ZRANGEBYSCORE from './ZRANGEBYSCORE';
 
-// describe('ZRANGEBYSCORE', () => {
+describe('ZRANGEBYSCORE', () => {
-//     describe('transformArguments', () => {
+  describe('transformArguments', () => {
-//         it('simple', () => {
+    it('simple', () => {
-//             assert.deepEqual(
+      assert.deepEqual(
-//                 transformArguments('src', 0, 1),
+        ZRANGEBYSCORE.transformArguments('src', 0, 1),
-//                 ['ZRANGEBYSCORE', 'src', '0', '1']
+        ['ZRANGEBYSCORE', 'src', '0', '1']
-//             );
+      );
-//         });
+    });
 
-//         it('with LIMIT', () => {
+    it('with LIMIT', () => {
-//             assert.deepEqual(
+      assert.deepEqual(
-//                 transformArguments('src', 0, 1, {
+        ZRANGEBYSCORE.transformArguments('src', 0, 1, {
-//                     LIMIT: {
+          LIMIT: {
-//                         offset: 0,
+            offset: 0,
-//                         count: 1
+            count: 1
-//                     }
+          }
-//                 }),
+        }),
-//                 ['ZRANGEBYSCORE', 'src', '0', '1', 'LIMIT', '0', '1']
+        ['ZRANGEBYSCORE', 'src', '0', '1', 'LIMIT', '0', '1']
-//             );
+      );
-//         });
+    });
-//     });
+  });
 
-//     testUtils.testWithClient('client.zRangeByScore', async client => {
+  testUtils.testAll('zRangeByScore', async client => {
-//         assert.deepEqual(
+    assert.deepEqual(
-//             await client.zRangeByScore('src', 0, 1),
+      await client.zRangeByScore('src', 0, 1),
-//             []
+      []
-//         );
+    );
-//     }, GLOBAL.SERVERS.OPEN);
+  }, {
-// });
+    client: GLOBAL.SERVERS.OPEN,
+    cluster: GLOBAL.CLUSTERS.OPEN
+  });
+});

packages/client/lib/commands/ZRANGEBYSCORE.ts

@@ -1,35 +1,36 @@
-// import { RedisCommandArgument, RedisCommandArguments } from '.';
+import { RedisArgument, ArrayReply, BlobStringReply, Command } from '../RESP/types';
-// import { transformStringDoubleArgument } from './generic-transformers';
+import { transformStringDoubleArgument } from './generic-transformers';
 
-// export const FIRST_KEY_INDEX = 1;
+export interface ZRangeByScoreOptions {
+  LIMIT?: {
+    offset: number;
+    count: number;
+  };
+}
 
-// export const IS_READ_ONLY = true;
+export declare function transformReply(): Array<RedisArgument>;
 
-// export interface ZRangeByScoreOptions {
+export default {
-//     LIMIT?: {
+  FIRST_KEY_INDEX: 1,
-//         offset: number;
+  IS_READ_ONLY: true,
-//         count: number;
+  transformArguments(
-//     };
+    key: RedisArgument,
-// }
+    min: string | number,
+    max: string | number,
+    options?: ZRangeByScoreOptions
+  ) {
+    const args = [
+      'ZRANGEBYSCORE',
+      key,
+      transformStringDoubleArgument(min),
+      transformStringDoubleArgument(max)
+    ];
 
-// export function transformArguments(
+    if (options?.LIMIT) {
-//     key: RedisCommandArgument,
+      args.push('LIMIT', options.LIMIT.offset.toString(), options.LIMIT.count.toString());
-//     min: string | number,
+    }
-//     max: string | number,
-//     options?: ZRangeByScoreOptions
-// ): RedisCommandArguments {
-//     const args = [
-//         'ZRANGEBYSCORE',
-//         key,
-//         transformStringDoubleArgument(min),
-//         transformStringDoubleArgument(max)
-//     ];
 
-//     if (options?.LIMIT) {
+    return args;
-//         args.push('LIMIT', options.LIMIT.offset.toString(), options.LIMIT.count.toString());
+  },
-//     }
+  transformReply: undefined as unknown as () => ArrayReply<BlobStringReply>
-
+} as const satisfies Command;
-//     return args;
-// }
-
-// export declare function transformReply(): Array<RedisCommandArgument>;

packages/client/lib/commands/index.ts

@@ -165,6 +165,7 @@ import ZRANDMEMBER_COUNT_WITHSCORES from './ZRANDMEMBER_COUNT_WITHSCORES';
 import ZRANDMEMBER_COUNT from './ZRANDMEMBER_COUNT';
 import ZRANDMEMBER from './ZRANDMEMBER';
 import ZRANGE from './ZRANGE';
+import ZRANGEBYSCORE from './ZRANGEBYSCORE';
 import ZRANK from './ZRANK';
 import ZREM from './ZREM';
 import ZREVRANK from './ZREVRANK';
@@ -510,6 +511,8 @@ export default {
   zRandMember: ZRANDMEMBER,
   ZRANGE,
   zRange: ZRANGE,
+  ZRANGEBYSCORE,
+  zRangeByScore: ZRANGEBYSCORE,
   ZRANK,
   zRank: ZRANK,
   ZREM,

todo.md

@@ -18,7 +18,6 @@
 - `ZREMRANGEBYLEX.ts`
 - `ZREMRANGEBYRANK.ts`
 - `ZREMRANGEBYSCORE.ts`
-- `ZUNIONSTORE.ts`
 
 # fot leiba
 - `BZMPOP.ts`