redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-06 02:15:48 +03:00
Code Activity

fix ZRANGEBYSCORE

Browse Source
This commit is contained in:
dovi
2023-05-02 17:54:55 -04:00
parent 31c91decec
commit 28d8215b6d
4 changed files with 67 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
packages/client/lib/commands/ZRANGEBYSCORE.spec.ts
View File

@@ -1,33 +1,36 @@
// import { strict as assert } from 'assert';
// import testUtils, { GLOBAL } from '../test-utils';
// import { transformArguments } from './ZRANGEBYSCORE';
import { strict as assert } from 'assert';
import testUtils, { GLOBAL } from '../test-utils';
import ZRANGEBYSCORE from './ZRANGEBYSCORE';
// describe('ZRANGEBYSCORE', () => {
// describe('transformArguments', () => {
// it('simple', () => {
// assert.deepEqual(
// transformArguments('src', 0, 1),
// ['ZRANGEBYSCORE', 'src', '0', '1']
// );
// });
describe('ZRANGEBYSCORE', () => {
describe('transformArguments', () => {
it('simple', () => {
assert.deepEqual(
ZRANGEBYSCORE.transformArguments('src', 0, 1),
['ZRANGEBYSCORE', 'src', '0', '1']
);
});
// it('with LIMIT', () => {
// assert.deepEqual(
// transformArguments('src', 0, 1, {
// LIMIT: {
// offset: 0,
// count: 1
// }
// }),
// ['ZRANGEBYSCORE', 'src', '0', '1', 'LIMIT', '0', '1']
// );
// });
// });
it('with LIMIT', () => {
assert.deepEqual(
ZRANGEBYSCORE.transformArguments('src', 0, 1, {
LIMIT: {
offset: 0,
count: 1
}
}),
['ZRANGEBYSCORE', 'src', '0', '1', 'LIMIT', '0', '1']
);
});
});
// testUtils.testWithClient('client.zRangeByScore', async client => {
// assert.deepEqual(
// await client.zRangeByScore('src', 0, 1),
// []
// );
// }, GLOBAL.SERVERS.OPEN);
// });
testUtils.testAll('zRangeByScore', async client => {
assert.deepEqual(
await client.zRangeByScore('src', 0, 1),
[]
);
}, {
client: GLOBAL.SERVERS.OPEN,
cluster: GLOBAL.CLUSTERS.OPEN
});
});

61
packages/client/lib/commands/ZRANGEBYSCORE.ts
View File

@@ -1,35 +1,36 @@
// import { RedisCommandArgument, RedisCommandArguments } from '.';
// import { transformStringDoubleArgument } from './generic-transformers';
import { RedisArgument, ArrayReply, BlobStringReply, Command } from '../RESP/types';
import { transformStringDoubleArgument } from './generic-transformers';
// export const FIRST_KEY_INDEX = 1;
export interface ZRangeByScoreOptions {
LIMIT?: {
offset: number;
count: number;
};
}
// export const IS_READ_ONLY = true;
export declare function transformReply(): Array<RedisArgument>;
// export interface ZRangeByScoreOptions {
// LIMIT?: {
// offset: number;
// count: number;
// };
// }
export default {
FIRST_KEY_INDEX: 1,
IS_READ_ONLY: true,
transformArguments(
key: RedisArgument,
min: string | number,
max: string | number,
options?: ZRangeByScoreOptions
) {
const args = [
'ZRANGEBYSCORE',
key,
transformStringDoubleArgument(min),
transformStringDoubleArgument(max)
];
// export function transformArguments(
// key: RedisCommandArgument,
// min: string | number,
// max: string | number,
// options?: ZRangeByScoreOptions
// ): RedisCommandArguments {
// const args = [
// 'ZRANGEBYSCORE',
// key,
// transformStringDoubleArgument(min),
// transformStringDoubleArgument(max)
// ];
if (options?.LIMIT) {
args.push('LIMIT', options.LIMIT.offset.toString(), options.LIMIT.count.toString());
}
// if (options?.LIMIT) {
// args.push('LIMIT', options.LIMIT.offset.toString(), options.LIMIT.count.toString());
// }
// return args;
// }
// export declare function transformReply(): Array<RedisCommandArgument>;
return args;
},
transformReply: undefined as unknown as () => ArrayReply<BlobStringReply>
} as const satisfies Command;

3
packages/client/lib/commands/index.ts
View File

@@ -165,6 +165,7 @@ import ZRANDMEMBER_COUNT_WITHSCORES from './ZRANDMEMBER_COUNT_WITHSCORES';
import ZRANDMEMBER_COUNT from './ZRANDMEMBER_COUNT';
import ZRANDMEMBER from './ZRANDMEMBER';
import ZRANGE from './ZRANGE';
import ZRANGEBYSCORE from './ZRANGEBYSCORE';
import ZRANK from './ZRANK';
import ZREM from './ZREM';
import ZREVRANK from './ZREVRANK';
@@ -510,6 +511,8 @@ export default {
zRandMember: ZRANDMEMBER,
ZRANGE,
zRange: ZRANGE,
ZRANGEBYSCORE,
zRangeByScore: ZRANGEBYSCORE,
ZRANK,
zRank: ZRANK,
ZREM,