redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-07 13:22:56 +03:00
Code Activity

Optimize statements and speed up the common case

Browse Source
This commit is contained in:
Ruben Bridgewater
2015-10-02 20:21:13 +02:00
parent 2ca42417bf
commit 2744fe8650
4 changed files with 21 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.gitignore vendored
View File

@@ -2,5 +2,5 @@ node_modules
.tern-port .tern-port
.nyc_output .nyc_output
coverage coverage
npm-debug.log *.log
*.rdb *.rdb

2
benchmarks/multi_bench.js
View File

@@ -7,7 +7,7 @@ var redis = require("../index");
var totalTime = 0; var totalTime = 0;
var metrics = require("metrics"); var metrics = require("metrics");
var num_clients = parseInt(process.argv[2], 10) || 5; var num_clients = parseInt(process.argv[2], 10) || 5;
var num_requests = 20000; var num_requests = 50000;
var tests = []; var tests = [];
var versions_logged = false; var versions_logged = false;
var client_options = { var client_options = {

22
index.js
View File

@@ -851,6 +851,14 @@ commands.forEach(function (fullCommand) {
arg = [key].concat(arg); arg = [key].concat(arg);
return this.send_command(command, arg, callback); return this.send_command(command, arg, callback);
} }
// Speed up the common case
var len = arguments.length;
if (len === 2) {
return this.send_command(command, [key, arg]);
}
if (len === 3) {
return this.send_command(command, [key, arg, callback]);
}
return this.send_command(command, utils.to_array(arguments)); return this.send_command(command, utils.to_array(arguments));
}; };
RedisClient.prototype[command.toUpperCase()] = RedisClient.prototype[command]; RedisClient.prototype[command.toUpperCase()] = RedisClient.prototype[command];
@@ -867,7 +875,15 @@ commands.forEach(function (fullCommand) {
} }
this.queue.push([command, key].concat(arg)); this.queue.push([command, key].concat(arg));
} else { } else {
this.queue.push([command].concat(utils.to_array(arguments))); // Speed up the common case
var len = arguments.length;
if (len === 2) {
this.queue.push([command, key, arg]);
} else if (len === 3) {
this.queue.push([command, key, arg, callback]);
} else {
this.queue.push([command].concat(utils.to_array(arguments)));
}
} }
return this; return this;
}; };
@@ -1102,9 +1118,7 @@ var createClient_tcp = function (port_arg, host_arg, options) {
exports.createClient = function(port_arg, host_arg, options) { exports.createClient = function(port_arg, host_arg, options) {
if (typeof port_arg === 'object' || port_arg === undefined) { if (typeof port_arg === 'object' || port_arg === undefined) {
options = port_arg || options || {}; options = port_arg || options || {};
var host = options.host || default_host; return createClient_tcp(+options.port, options.host, options);
var port = +options.port || default_port;
return createClient_tcp(port, host, options);
} }
if (typeof port_arg === 'number' || typeof port_arg === 'string' && /^\d+$/.test(port_arg)) { if (typeof port_arg === 'number' || typeof port_arg === 'string' && /^\d+$/.test(port_arg)) {
return createClient_tcp(port_arg, host_arg, options); return createClient_tcp(port_arg, host_arg, options);

10
lib/parsers/javascript.js
View File

@@ -11,7 +11,7 @@ function ReplyParser(return_buffers) {
this.name = exports.name; this.name = exports.name;
this.return_buffers = return_buffers; this.return_buffers = return_buffers;
this._buffer = null; this._buffer = new Buffer(0);
this._offset = 0; this._offset = 0;
this._encoding = "utf-8"; this._encoding = "utf-8";
} }
@@ -171,18 +171,10 @@ ReplyParser.prototype.execute = function (buffer) {
ReplyParser.prototype.append = function (newBuffer) { ReplyParser.prototype.append = function (newBuffer) {
// first run
if (this._buffer === null) {
this._buffer = newBuffer;
return;
}
// out of data // out of data
if (this._offset >= this._buffer.length) { if (this._offset >= this._buffer.length) {
this._buffer = newBuffer; this._buffer = newBuffer;
this._offset = 0; this._offset = 0;
return; return;
} }