redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-06 02:15:48 +03:00
Code Activity

fix(sentinel): Migrated to the new testing framework, fixed issues that were discovered during transition

Browse Source 
* [CAE-342] Fix a couple of bugs

* Fixed issue with nodes masterauth persistency, changed docker container

* [CAE-342] Fixed a couple of sentinel issues, enabled most tests

* [CAE-342] Added comment

* [CAE-342] Migrate majority of tests to testUtils

* [CAE-342] Minor refactor

* .

* [CAE-342] Using cae containers for sentinel

* [CAE-342] Improved resiliency of the legacy tests, added TSdoc comment

* [CAE-342] Some extra logging, removed unneeded changes

* [CAE-342] Moved docker env as optional part of redisserverdockerconfig

* [CAE-342] Move password to serverArguments

* [CAE-342] Moved ts-node to devDependencies

* [CAE-342] Reverted legacy testing framework improvements
This commit is contained in:
Hristo Temelski
2025-04-30 15:56:29 +03:00
committed by GitHub
parent 048df302e4
commit 10ff6debab
9 changed files with 1459 additions and 1253 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
packages/client/lib/sentinel/index.ts
View File

@@ -345,9 +345,12 @@ export default class RedisSentinel<
key: K,
value: V
) {
const proxy = Object.create(this._self);
proxy._commandOptions = Object.create(this._self.#commandOptions ?? null);
proxy._commandOptions[key] = value;
const proxy = Object.create(this);
// Create new commandOptions object with the inherited properties
proxy._self.#commandOptions = {
...(this._self.#commandOptions || {}),
[key]: value
};
return proxy as RedisSentinelType<
M,
F,
@@ -682,9 +685,10 @@ class RedisSentinelInternal<
async #connect() {
let count = 0;
while (true) {
while (true) {
this.#trace("starting connect loop");
count+=1;
if (this.#destroy) {
this.#trace("in #connect and want to destroy")
return;
@@ -1109,7 +1113,7 @@ class RedisSentinelInternal<
this.#trace(`transform: destroying old masters if open`);
for (const client of this.#masterClients) {
masterWatches.push(client.isWatching);
masterWatches.push(client.isWatching || client.isDirtyWatch);
if (client.isOpen) {
client.destroy()
@@ -1460,4 +1464,4 @@ export class RedisSentinelFactory extends EventEmitter {
}
});
}
}
}