redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-04 15:02:09 +03:00
Code Activity

use setImmediate instead of queueMicrotask (to improve performance) (#2516)

Browse Source
This commit is contained in:
Leibale Eidelman
2023-05-29 09:01:22 -04:00
committed by GitHub
parent e696653bf9
commit 100a5232ac
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/FAQ.md
View File

@@ -10,7 +10,7 @@ If don't want to queue commands in memory until a new socket is established, set
## How are commands batched? ## How are commands batched?
Commands are pipelined using [`queueMicrotask`](https://nodejs.org/api/globals.html#globals_queuemicrotask_callback). Commands are pipelined using [`setImmediate`](https://nodejs.org/api/timers.html#setimmediatecallback-args).
If `socket.write()` returns `false`—meaning that ["all or part of the data was queued in user memory"](https://nodejs.org/api/net.html#net_socket_write_data_encoding_callback:~:text=all%20or%20part%20of%20the%20data%20was%20queued%20in%20user%20memory)—the commands will stack in memory until the [`drain`](https://nodejs.org/api/net.html#net_event_drain) event is fired. If `socket.write()` returns `false`—meaning that ["all or part of the data was queued in user memory"](https://nodejs.org/api/net.html#net_socket_write_data_encoding_callback:~:text=all%20or%20part%20of%20the%20data%20was%20queued%20in%20user%20memory)—the commands will stack in memory until the [`drain`](https://nodejs.org/api/net.html#net_event_drain) event is fired.

2
packages/client/lib/client/socket.ts
View File

@@ -291,7 +291,7 @@ export default class RedisSocket extends EventEmitter {
this.#socket.cork(); this.#socket.cork();
this.#isCorked = true; this.#isCorked = true;
queueMicrotask(() => { setImmediate(() => {
this.#socket?.uncork(); this.#socket?.uncork();
this.#isCorked = false; this.#isCorked = false;
}); });