redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-04 15:02:09 +03:00
Code Activity

Execute empty MULTI (#2423)

Browse Source 
* Fix multi.exec with empty queue and previous watch

When calling exec on a multi instance which you did not use, no command is sent currently.

This is a problem for watched keys, because no EXEC means no unwatch, which might cause hard-to-debug problems.

Proposed Fix: Sending UNWATCH

* execute empty multi command (instead of skipping)

* Update index.ts

* Update index.ts

* Update multi-command.ts

* Update multi-command.ts

* Update multi-command.ts

* Update multi-command.ts

* short circuit empty pipelines

* Update index.ts

---------

Co-authored-by: Leibale <me@leibale.com>
This commit is contained in:
Mik13
2023-02-24 23:33:16 +01:00
committed by GitHub
parent 1be84228b5
commit 0f28dad2a2
6 changed files with 46 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/client/lib/multi-command.ts
View File

@@ -69,18 +69,6 @@ export default class RedisMultiCommand {
return transformedArguments;
}
exec(): undefined | Array<RedisMultiQueuedCommand> {
if (!this.queue.length) {
return;
}
return [
{ args: ['MULTI'] },
...this.queue,
{ args: ['EXEC'] }
];
}
handleExecReplies(rawReplies: Array<RedisCommandRawReply>): Array<RedisCommandRawReply> {
const execReply = rawReplies[rawReplies.length - 1] as (null | Array<RedisCommandRawReply>);
if (execReply === null) {