redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-06 02:15:48 +03:00
Code Activity

add missing fields support to schema (v4) (#2789)

Browse Source
This commit is contained in:
Shaya Potter
2024-07-17 11:36:45 +03:00
committed by GitHub
parent 64fca37944
commit 0e7e2e6e29
2 changed files with 62 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
packages/search/lib/commands/CREATE.spec.ts
View File

@@ -441,6 +441,36 @@ describe('CREATE', () => {
);
});
});
describe('Missing Values', () => {
it('with INDEXEMPTY', () => {
assert.deepEqual(
transformArguments('index', {
field: {
type: SchemaFieldTypes.TEXT,
MISSING_VALUES: {
INDEXEMPTY: true
}
}
}),
['FT.CREATE', 'index', 'SCHEMA', 'field', 'TEXT', 'INDEXEMPTY']
);
});
it('with INDEXMISSING', () => {
assert.deepEqual(
transformArguments('index', {
field: {
type: SchemaFieldTypes.TEXT,
MISSING_VALUES: {
INDEXMISSING: true
}
}
}),
['FT.CREATE', 'index', 'SCHEMA', 'field', 'TEXT', 'INDEXMISSING']
);
});
});
});
testUtils.testWithClient('client.ft.create', async client => {

35
packages/search/lib/commands/index.ts
View File

@@ -189,12 +189,32 @@ export enum SchemaFieldTypes {
GEOSHAPE = 'GEOSHAPE'
}
export interface MissingValues {
INDEXEMPTY?: boolean;
INDEXMISSING?: boolean;
}
function pushMissingValues(args: RedisCommandArguments, missingValues?: MissingValues) {
if (!missingValues) {
return;
}
if (missingValues.INDEXEMPTY) {
args.push("INDEXEMPTY");
}
if (missingValues.INDEXMISSING) {
args.push("INDEXMISSING");
}
}
type CreateSchemaField<
T extends SchemaFieldTypes,
E = Record<PropertyKey, unknown>
> = T | ({
type: T;
AS?: string;
MISSING_VALUES?: MissingValues;
} & E);
type CreateSchemaCommonField<
@@ -313,11 +333,14 @@ export function pushSchema(args: RedisCommandArguments, schema: RediSearchSchema
args.push('WITHSUFFIXTRIE');
}
pushMissingValues(args, fieldOptions.MISSING_VALUES);
break;
// case SchemaFieldTypes.NUMERIC:
// case SchemaFieldTypes.GEO:
// break;
case SchemaFieldTypes.NUMERIC:
case SchemaFieldTypes.GEO:
pushMissingValues(args, fieldOptions.MISSING_VALUES);
break;
case SchemaFieldTypes.TAG:
if (fieldOptions.SEPARATOR) {
@@ -332,6 +355,8 @@ export function pushSchema(args: RedisCommandArguments, schema: RediSearchSchema
args.push('WITHSUFFIXTRIE');
}
pushMissingValues(args, fieldOptions.MISSING_VALUES);
break;
case SchemaFieldTypes.VECTOR:
@@ -373,6 +398,8 @@ export function pushSchema(args: RedisCommandArguments, schema: RediSearchSchema
}
});
pushMissingValues(args, fieldOptions.MISSING_VALUES);
continue; // vector fields do not contain SORTABLE and NOINDEX options
case SchemaFieldTypes.GEOSHAPE:
@@ -380,6 +407,8 @@ export function pushSchema(args: RedisCommandArguments, schema: RediSearchSchema
args.push('COORD_SYSTEM', fieldOptions.COORD_SYSTEM);
}
pushMissingValues(args, fieldOptions.MISSING_VALUES);
continue; // geo shape fields do not contain SORTABLE and NOINDEX options
}