1
0
mirror of https://github.com/redis/node-redis.git synced 2025-08-09 00:22:08 +03:00

Remove event emitters from the parser as they are overhead that is not needed

This commit is contained in:
Ruben Bridgewater
2015-09-05 17:10:27 +02:00
parent 75b3fdb495
commit 0170145f74
4 changed files with 8 additions and 39 deletions

View File

@@ -1,8 +1,6 @@
'use strict';
var events = require("events"),
util = require("util"),
hiredis = require("hiredis");
var hiredis = require("hiredis");
exports.name = "hiredis";
@@ -10,11 +8,8 @@ function HiredisReplyParser(options) {
this.name = exports.name;
this.options = options || {};
this.reset();
events.EventEmitter.call(this);
}
util.inherits(HiredisReplyParser, events.EventEmitter);
exports.Parser = HiredisReplyParser;
HiredisReplyParser.prototype.reset = function () {
@@ -27,21 +22,16 @@ HiredisReplyParser.prototype.execute = function (data) {
var reply;
this.reader.feed(data);
while (true) {
try {
reply = this.reader.get();
} catch (err) {
this.emit("error", err);
break;
}
reply = this.reader.get();
if (reply === undefined) {
break;
}
if (reply && reply.constructor === Error) {
this.emit("reply error", reply);
this.send_error(reply);
} else {
this.emit("reply", reply);
this.send_reply(reply);
}
}
};

View File

@@ -1,7 +1,6 @@
'use strict';
var events = require("events"),
util = require("util");
var util = require("util");
function Packet(type, size) {
this.type = type;
@@ -20,8 +19,6 @@ function ReplyParser(options) {
this._reply_type = null;
}
util.inherits(ReplyParser, events.EventEmitter);
exports.Parser = ReplyParser;
function IncompleteReadBuffer(message) {
@@ -286,11 +283,3 @@ ReplyParser.prototype._packetEndOffset = function () {
ReplyParser.prototype._bytesRemaining = function () {
return (this._buffer.length - this._offset) < 0 ? 0 : (this._buffer.length - this._offset);
};
ReplyParser.prototype.send_error = function (reply) {
this.emit("reply error", reply);
};
ReplyParser.prototype.send_reply = function (reply) {
this.emit("reply", reply);
};