mirror of
https://github.com/redis/go-redis.git
synced 2025-11-24 18:41:04 +03:00
* wip * wip, used and unusable states * polish state machine * correct handling OnPut * better errors for tests, hook should work now * fix linter * improve reauth state management. fix tests * Update internal/pool/conn.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update internal/pool/conn.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * better timeouts * empty endpoint handoff case * fix handoff state when queued for handoff * try to detect the deadlock * try to detect the deadlock x2 * delete should be called * improve tests * fix mark on uninitialized connection * Update internal/pool/conn_state_test.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update internal/pool/conn_state_test.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update internal/pool/pool.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update internal/pool/conn_state.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update internal/pool/conn.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix error from copilot * address copilot comment * fix(pool): pool performance (#3565) * perf(pool): replace hookManager RWMutex with atomic.Pointer and add predefined state slices - Replace hookManager RWMutex with atomic.Pointer for lock-free reads in hot paths - Add predefined state slices to avoid allocations (validFromInUse, validFromCreatedOrIdle, etc.) - Add Clone() method to PoolHookManager for atomic updates - Update AddPoolHook/RemovePoolHook to use copy-on-write pattern - Update all hookManager access points to use atomic Load() Performance improvements: - Eliminates RWMutex contention in Get/Put/Remove hot paths - Reduces allocations by reusing predefined state slices - Lock-free reads allow better CPU cache utilization * perf(pool): eliminate mutex overhead in state machine hot path The state machine was calling notifyWaiters() on EVERY Get/Put operation, which acquired a mutex even when no waiters were present (the common case). Fix: Use atomic waiterCount to check for waiters BEFORE acquiring mutex. This eliminates mutex contention in the hot path (Get/Put operations). Implementation: - Added atomic.Int32 waiterCount field to ConnStateMachine - Increment when adding waiter, decrement when removing - Check waiterCount atomically before acquiring mutex in notifyWaiters() Performance impact: - Before: mutex lock/unlock on every Get/Put (even with no waiters) - After: lock-free atomic check, only acquire mutex if waiters exist - Expected improvement: ~30-50% for Get/Put operations * perf(pool): use predefined state slices to eliminate allocations in hot path The pool was creating new slice literals on EVERY Get/Put operation: - popIdle(): []ConnState{StateCreated, StateIdle} - putConn(): []ConnState{StateInUse} - CompareAndSwapUsed(): []ConnState{StateIdle} and []ConnState{StateInUse} - MarkUnusableForHandoff(): []ConnState{StateInUse, StateIdle, StateCreated} These allocations were happening millions of times per second in the hot path. Fix: Use predefined global slices defined in conn_state.go: - validFromInUse - validFromCreatedOrIdle - validFromCreatedInUseOrIdle Performance impact: - Before: 4 slice allocations per Get/Put cycle - After: 0 allocations (use predefined slices) - Expected improvement: ~30-40% reduction in allocations and GC pressure * perf(pool): optimize TryTransition to reduce atomic operations Further optimize the hot path by: 1. Remove redundant GetState() call in the loop 2. Only check waiterCount after successful CAS (not before loop) 3. Inline the waiterCount check to avoid notifyWaiters() call overhead This reduces atomic operations from 4-5 per Get/Put to 2-3: - Before: GetState() + CAS + waiterCount.Load() + notifyWaiters mutex check - After: CAS + waiterCount.Load() (only if CAS succeeds) Performance impact: - Eliminates 1-2 atomic operations per Get/Put - Expected improvement: ~10-15% for Get/Put operations * perf(pool): add fast path for Get/Put to match master performance Introduced TryTransitionFast() for the hot path (Get/Put operations): - Single CAS operation (same as master's atomic bool) - No waiter notification overhead - No loop through valid states - No error allocation Hot path flow: 1. popIdle(): Try IDLE → IN_USE (fast), fallback to CREATED → IN_USE 2. putConn(): Try IN_USE → IDLE (fast) This matches master's performance while preserving state machine for: - Background operations (handoff/reauth use UNUSABLE state) - State validation (TryTransition still available) - Waiter notification (AwaitAndTransition for blocking) Performance comparison per Get/Put cycle: - Master: 2 atomic CAS operations - State machine (before): 5 atomic operations (2.5x slower) - State machine (after): 2 atomic CAS operations (same as master!) Expected improvement: Restore to baseline ~11,373 ops/sec * combine cas * fix linter * try faster approach * fast semaphore * better inlining for hot path * fix linter issues * use new semaphore in auth as well * linter should be happy now * add comments * Update internal/pool/conn_state.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * address comment * slight reordering * try to cache time if for non-critical calculation * fix wrong benchmark * add concurrent test * fix benchmark report * add additional expect to check output * comment and variable rename --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * initConn sets IDLE state - Handle unexpected conn state changes * fix precision of time cache and usedAt * allow e2e tests to run longer * Fix broken initialization of idle connections * optimize push notif * 100ms -> 50ms * use correct timer for last health check * verify pass auth on conn creation * fix assertion * fix unsafe test * fix benchmark test * improve remove conn * re doesn't support requirepass * wait more in e2e test * flaky test * add missed method in interface * fix test assertions * silence logs and faster hooks manager * address linter comment * fix flaky test * use read instad of control * use pool size for semsize * CAS instead of reading the state * preallocate errors and states * preallocate state slices * fix flaky test * fix fast semaphore that could have been starved * try to fix the semaphore * should properly notify the waiters - this way a waiter that timesout at the same time a releaser is releasing, won't throw token. the releaser will fail to notify and will pick another waiter. this hybrid approach should be faster than channels and maintains FIFO * waiter may double-release (if closed/times out) * priority of operations * use simple approach of fifo waiters * use simple channel based semaphores * address linter and tests * remove unused benchs * change log message * address pr comments * address pr comments * fix data race --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
193 lines
4.9 KiB
Go
193 lines
4.9 KiB
Go
package internal
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
"time"
|
|
)
|
|
|
|
var semTimers = sync.Pool{
|
|
New: func() interface{} {
|
|
t := time.NewTimer(time.Hour)
|
|
t.Stop()
|
|
return t
|
|
},
|
|
}
|
|
|
|
// FastSemaphore is a channel-based semaphore optimized for performance.
|
|
// It uses a fast path that avoids timer allocation when tokens are available.
|
|
// The channel is pre-filled with tokens: Acquire = receive, Release = send.
|
|
// Closing the semaphore unblocks all waiting goroutines.
|
|
//
|
|
// Performance: ~30 ns/op with zero allocations on fast path.
|
|
// Fairness: Eventual fairness (no starvation) but not strict FIFO.
|
|
type FastSemaphore struct {
|
|
tokens chan struct{}
|
|
max int32
|
|
}
|
|
|
|
// NewFastSemaphore creates a new fast semaphore with the given capacity.
|
|
func NewFastSemaphore(capacity int32) *FastSemaphore {
|
|
ch := make(chan struct{}, capacity)
|
|
// Pre-fill with tokens
|
|
for i := int32(0); i < capacity; i++ {
|
|
ch <- struct{}{}
|
|
}
|
|
return &FastSemaphore{
|
|
tokens: ch,
|
|
max: capacity,
|
|
}
|
|
}
|
|
|
|
// TryAcquire attempts to acquire a token without blocking.
|
|
// Returns true if successful, false if no tokens available.
|
|
func (s *FastSemaphore) TryAcquire() bool {
|
|
select {
|
|
case <-s.tokens:
|
|
return true
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
|
|
// Acquire acquires a token, blocking if necessary until one is available.
|
|
// Returns an error if the context is cancelled or the timeout expires.
|
|
// Uses a fast path to avoid timer allocation when tokens are immediately available.
|
|
func (s *FastSemaphore) Acquire(ctx context.Context, timeout time.Duration, timeoutErr error) error {
|
|
// Check context first
|
|
select {
|
|
case <-ctx.Done():
|
|
return ctx.Err()
|
|
default:
|
|
}
|
|
|
|
// Try fast path first (no timer needed)
|
|
select {
|
|
case <-s.tokens:
|
|
return nil
|
|
default:
|
|
}
|
|
|
|
// Slow path: need to wait with timeout
|
|
timer := semTimers.Get().(*time.Timer)
|
|
defer semTimers.Put(timer)
|
|
timer.Reset(timeout)
|
|
|
|
select {
|
|
case <-s.tokens:
|
|
if !timer.Stop() {
|
|
<-timer.C
|
|
}
|
|
return nil
|
|
case <-ctx.Done():
|
|
if !timer.Stop() {
|
|
<-timer.C
|
|
}
|
|
return ctx.Err()
|
|
case <-timer.C:
|
|
return timeoutErr
|
|
}
|
|
}
|
|
|
|
// AcquireBlocking acquires a token, blocking indefinitely until one is available.
|
|
func (s *FastSemaphore) AcquireBlocking() {
|
|
<-s.tokens
|
|
}
|
|
|
|
// Release releases a token back to the semaphore.
|
|
func (s *FastSemaphore) Release() {
|
|
s.tokens <- struct{}{}
|
|
}
|
|
|
|
// Close closes the semaphore, unblocking all waiting goroutines.
|
|
// After close, all Acquire calls will receive a closed channel signal.
|
|
func (s *FastSemaphore) Close() {
|
|
close(s.tokens)
|
|
}
|
|
|
|
// Len returns the current number of acquired tokens.
|
|
func (s *FastSemaphore) Len() int32 {
|
|
return s.max - int32(len(s.tokens))
|
|
}
|
|
|
|
// FIFOSemaphore is a channel-based semaphore with strict FIFO ordering.
|
|
// Unlike FastSemaphore, this guarantees that threads are served in the exact order they call Acquire().
|
|
// The channel is pre-filled with tokens: Acquire = receive, Release = send.
|
|
// Closing the semaphore unblocks all waiting goroutines.
|
|
//
|
|
// Performance: ~115 ns/op with zero allocations (slower than FastSemaphore due to timer allocation).
|
|
// Fairness: Strict FIFO ordering guaranteed by Go runtime.
|
|
type FIFOSemaphore struct {
|
|
tokens chan struct{}
|
|
max int32
|
|
}
|
|
|
|
// NewFIFOSemaphore creates a new FIFO semaphore with the given capacity.
|
|
func NewFIFOSemaphore(capacity int32) *FIFOSemaphore {
|
|
ch := make(chan struct{}, capacity)
|
|
// Pre-fill with tokens
|
|
for i := int32(0); i < capacity; i++ {
|
|
ch <- struct{}{}
|
|
}
|
|
return &FIFOSemaphore{
|
|
tokens: ch,
|
|
max: capacity,
|
|
}
|
|
}
|
|
|
|
// TryAcquire attempts to acquire a token without blocking.
|
|
// Returns true if successful, false if no tokens available.
|
|
func (s *FIFOSemaphore) TryAcquire() bool {
|
|
select {
|
|
case <-s.tokens:
|
|
return true
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
|
|
// Acquire acquires a token, blocking if necessary until one is available.
|
|
// Returns an error if the context is cancelled or the timeout expires.
|
|
// Always uses timer to guarantee FIFO ordering (no fast path).
|
|
func (s *FIFOSemaphore) Acquire(ctx context.Context, timeout time.Duration, timeoutErr error) error {
|
|
// No fast path - always use timer to guarantee FIFO
|
|
timer := semTimers.Get().(*time.Timer)
|
|
defer semTimers.Put(timer)
|
|
timer.Reset(timeout)
|
|
|
|
select {
|
|
case <-s.tokens:
|
|
if !timer.Stop() {
|
|
<-timer.C
|
|
}
|
|
return nil
|
|
case <-ctx.Done():
|
|
if !timer.Stop() {
|
|
<-timer.C
|
|
}
|
|
return ctx.Err()
|
|
case <-timer.C:
|
|
return timeoutErr
|
|
}
|
|
}
|
|
|
|
// AcquireBlocking acquires a token, blocking indefinitely until one is available.
|
|
func (s *FIFOSemaphore) AcquireBlocking() {
|
|
<-s.tokens
|
|
}
|
|
|
|
// Release releases a token back to the semaphore.
|
|
func (s *FIFOSemaphore) Release() {
|
|
s.tokens <- struct{}{}
|
|
}
|
|
|
|
// Close closes the semaphore, unblocking all waiting goroutines.
|
|
// After close, all Acquire calls will receive a closed channel signal.
|
|
func (s *FIFOSemaphore) Close() {
|
|
close(s.tokens)
|
|
}
|
|
|
|
// Len returns the current number of acquired tokens.
|
|
func (s *FIFOSemaphore) Len() int32 {
|
|
return s.max - int32(len(s.tokens))
|
|
} |