mirror of
https://github.com/redis/go-redis.git
synced 2025-12-03 18:31:14 +03:00
* perf(pool): replace hookManager RWMutex with atomic.Pointer and add predefined state slices
- Replace hookManager RWMutex with atomic.Pointer for lock-free reads in hot paths
- Add predefined state slices to avoid allocations (validFromInUse, validFromCreatedOrIdle, etc.)
- Add Clone() method to PoolHookManager for atomic updates
- Update AddPoolHook/RemovePoolHook to use copy-on-write pattern
- Update all hookManager access points to use atomic Load()
Performance improvements:
- Eliminates RWMutex contention in Get/Put/Remove hot paths
- Reduces allocations by reusing predefined state slices
- Lock-free reads allow better CPU cache utilization
* perf(pool): eliminate mutex overhead in state machine hot path
The state machine was calling notifyWaiters() on EVERY Get/Put operation,
which acquired a mutex even when no waiters were present (the common case).
Fix: Use atomic waiterCount to check for waiters BEFORE acquiring mutex.
This eliminates mutex contention in the hot path (Get/Put operations).
Implementation:
- Added atomic.Int32 waiterCount field to ConnStateMachine
- Increment when adding waiter, decrement when removing
- Check waiterCount atomically before acquiring mutex in notifyWaiters()
Performance impact:
- Before: mutex lock/unlock on every Get/Put (even with no waiters)
- After: lock-free atomic check, only acquire mutex if waiters exist
- Expected improvement: ~30-50% for Get/Put operations
* perf(pool): use predefined state slices to eliminate allocations in hot path
The pool was creating new slice literals on EVERY Get/Put operation:
- popIdle(): []ConnState{StateCreated, StateIdle}
- putConn(): []ConnState{StateInUse}
- CompareAndSwapUsed(): []ConnState{StateIdle} and []ConnState{StateInUse}
- MarkUnusableForHandoff(): []ConnState{StateInUse, StateIdle, StateCreated}
These allocations were happening millions of times per second in the hot path.
Fix: Use predefined global slices defined in conn_state.go:
- validFromInUse
- validFromCreatedOrIdle
- validFromCreatedInUseOrIdle
Performance impact:
- Before: 4 slice allocations per Get/Put cycle
- After: 0 allocations (use predefined slices)
- Expected improvement: ~30-40% reduction in allocations and GC pressure
* perf(pool): optimize TryTransition to reduce atomic operations
Further optimize the hot path by:
1. Remove redundant GetState() call in the loop
2. Only check waiterCount after successful CAS (not before loop)
3. Inline the waiterCount check to avoid notifyWaiters() call overhead
This reduces atomic operations from 4-5 per Get/Put to 2-3:
- Before: GetState() + CAS + waiterCount.Load() + notifyWaiters mutex check
- After: CAS + waiterCount.Load() (only if CAS succeeds)
Performance impact:
- Eliminates 1-2 atomic operations per Get/Put
- Expected improvement: ~10-15% for Get/Put operations
* perf(pool): add fast path for Get/Put to match master performance
Introduced TryTransitionFast() for the hot path (Get/Put operations):
- Single CAS operation (same as master's atomic bool)
- No waiter notification overhead
- No loop through valid states
- No error allocation
Hot path flow:
1. popIdle(): Try IDLE → IN_USE (fast), fallback to CREATED → IN_USE
2. putConn(): Try IN_USE → IDLE (fast)
This matches master's performance while preserving state machine for:
- Background operations (handoff/reauth use UNUSABLE state)
- State validation (TryTransition still available)
- Waiter notification (AwaitAndTransition for blocking)
Performance comparison per Get/Put cycle:
- Master: 2 atomic CAS operations
- State machine (before): 5 atomic operations (2.5x slower)
- State machine (after): 2 atomic CAS operations (same as master!)
Expected improvement: Restore to baseline ~11,373 ops/sec
* combine cas
* fix linter
* try faster approach
* fast semaphore
* better inlining for hot path
* fix linter issues
* use new semaphore in auth as well
* linter should be happy now
* add comments
* Update internal/pool/conn_state.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* address comment
* slight reordering
* try to cache time if for non-critical calculation
* fix wrong benchmark
* add concurrent test
* fix benchmark report
* add additional expect to check output
* comment and variable rename
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
156 lines
4.6 KiB
Go
156 lines
4.6 KiB
Go
package pool
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
)
|
|
|
|
// PoolHook defines the interface for connection lifecycle hooks.
|
|
type PoolHook interface {
|
|
// OnGet is called when a connection is retrieved from the pool.
|
|
// It can modify the connection or return an error to prevent its use.
|
|
// The accept flag can be used to prevent the connection from being used.
|
|
// On Accept = false the connection is rejected and returned to the pool.
|
|
// The error can be used to prevent the connection from being used and returned to the pool.
|
|
// On Errors, the connection is removed from the pool.
|
|
// It has isNewConn flag to indicate if this is a new connection (rather than idle from the pool)
|
|
// The flag can be used for gathering metrics on pool hit/miss ratio.
|
|
OnGet(ctx context.Context, conn *Conn, isNewConn bool) (accept bool, err error)
|
|
|
|
// OnPut is called when a connection is returned to the pool.
|
|
// It returns whether the connection should be pooled and whether it should be removed.
|
|
OnPut(ctx context.Context, conn *Conn) (shouldPool bool, shouldRemove bool, err error)
|
|
|
|
// OnRemove is called when a connection is removed from the pool.
|
|
// This happens when:
|
|
// - Connection fails health check
|
|
// - Connection exceeds max lifetime
|
|
// - Pool is being closed
|
|
// - Connection encounters an error
|
|
// Implementations should clean up any per-connection state.
|
|
// The reason parameter indicates why the connection was removed.
|
|
OnRemove(ctx context.Context, conn *Conn, reason error)
|
|
}
|
|
|
|
// PoolHookManager manages multiple pool hooks.
|
|
type PoolHookManager struct {
|
|
hooks []PoolHook
|
|
hooksMu sync.RWMutex
|
|
}
|
|
|
|
// NewPoolHookManager creates a new pool hook manager.
|
|
func NewPoolHookManager() *PoolHookManager {
|
|
return &PoolHookManager{
|
|
hooks: make([]PoolHook, 0),
|
|
}
|
|
}
|
|
|
|
// AddHook adds a pool hook to the manager.
|
|
// Hooks are called in the order they were added.
|
|
func (phm *PoolHookManager) AddHook(hook PoolHook) {
|
|
phm.hooksMu.Lock()
|
|
defer phm.hooksMu.Unlock()
|
|
phm.hooks = append(phm.hooks, hook)
|
|
}
|
|
|
|
// RemoveHook removes a pool hook from the manager.
|
|
func (phm *PoolHookManager) RemoveHook(hook PoolHook) {
|
|
phm.hooksMu.Lock()
|
|
defer phm.hooksMu.Unlock()
|
|
|
|
for i, h := range phm.hooks {
|
|
if h == hook {
|
|
// Remove hook by swapping with last element and truncating
|
|
phm.hooks[i] = phm.hooks[len(phm.hooks)-1]
|
|
phm.hooks = phm.hooks[:len(phm.hooks)-1]
|
|
break
|
|
}
|
|
}
|
|
}
|
|
|
|
// ProcessOnGet calls all OnGet hooks in order.
|
|
// If any hook returns an error, processing stops and the error is returned.
|
|
func (phm *PoolHookManager) ProcessOnGet(ctx context.Context, conn *Conn, isNewConn bool) (acceptConn bool, err error) {
|
|
phm.hooksMu.RLock()
|
|
defer phm.hooksMu.RUnlock()
|
|
|
|
for _, hook := range phm.hooks {
|
|
acceptConn, err := hook.OnGet(ctx, conn, isNewConn)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
|
|
if !acceptConn {
|
|
return false, nil
|
|
}
|
|
}
|
|
return true, nil
|
|
}
|
|
|
|
// ProcessOnPut calls all OnPut hooks in order.
|
|
// The first hook that returns shouldRemove=true or shouldPool=false will stop processing.
|
|
func (phm *PoolHookManager) ProcessOnPut(ctx context.Context, conn *Conn) (shouldPool bool, shouldRemove bool, err error) {
|
|
phm.hooksMu.RLock()
|
|
defer phm.hooksMu.RUnlock()
|
|
|
|
shouldPool = true // Default to pooling the connection
|
|
|
|
for _, hook := range phm.hooks {
|
|
hookShouldPool, hookShouldRemove, hookErr := hook.OnPut(ctx, conn)
|
|
|
|
if hookErr != nil {
|
|
return false, true, hookErr
|
|
}
|
|
|
|
// If any hook says to remove or not pool, respect that decision
|
|
if hookShouldRemove {
|
|
return false, true, nil
|
|
}
|
|
|
|
if !hookShouldPool {
|
|
shouldPool = false
|
|
}
|
|
}
|
|
|
|
return shouldPool, false, nil
|
|
}
|
|
|
|
// ProcessOnRemove calls all OnRemove hooks in order.
|
|
func (phm *PoolHookManager) ProcessOnRemove(ctx context.Context, conn *Conn, reason error) {
|
|
phm.hooksMu.RLock()
|
|
defer phm.hooksMu.RUnlock()
|
|
for _, hook := range phm.hooks {
|
|
hook.OnRemove(ctx, conn, reason)
|
|
}
|
|
}
|
|
|
|
// GetHookCount returns the number of registered hooks (for testing).
|
|
func (phm *PoolHookManager) GetHookCount() int {
|
|
phm.hooksMu.RLock()
|
|
defer phm.hooksMu.RUnlock()
|
|
return len(phm.hooks)
|
|
}
|
|
|
|
// GetHooks returns a copy of all registered hooks.
|
|
func (phm *PoolHookManager) GetHooks() []PoolHook {
|
|
phm.hooksMu.RLock()
|
|
defer phm.hooksMu.RUnlock()
|
|
|
|
hooks := make([]PoolHook, len(phm.hooks))
|
|
copy(hooks, phm.hooks)
|
|
return hooks
|
|
}
|
|
|
|
// Clone creates a copy of the hook manager with the same hooks.
|
|
// This is used for lock-free atomic updates of the hook manager.
|
|
func (phm *PoolHookManager) Clone() *PoolHookManager {
|
|
phm.hooksMu.RLock()
|
|
defer phm.hooksMu.RUnlock()
|
|
|
|
newManager := &PoolHookManager{
|
|
hooks: make([]PoolHook, len(phm.hooks)),
|
|
}
|
|
copy(newManager.hooks, phm.hooks)
|
|
return newManager
|
|
}
|