redis/go-redis
1
0
Fork 0
mirror of https://github.com/redis/go-redis.git synced 2025-10-18 22:08:50 +03:00
Code Activity
2,776 Commits 69 Branches 443 Tags
ndyakov/pool-reauth
Commit Graph

292 Commits

Author SHA1 Message Date
Nedyalko Dyakov
f14095b12c only async reauth 2025-10-17 17:39:47 +03:00
Nedyalko Dyakov
f8867759da pass hooks so the tests can observe reauth 2025-10-17 16:38:33 +03:00
Nedyalko Dyakov
afba8c285f fix nil listener 2025-10-17 15:17:13 +03:00
Nedyalko Dyakov
d74671b094 fix maintnotif pool hook 2025-10-17 13:47:30 +03:00
Nedyalko Dyakov
acb55d8741 wip refactor entraid 2025-10-17 12:42:52 +03:00
Nedyalko Dyakov
391b6c523c address pr comments 2025-10-15 19:22:02 +03:00
Nedyalko Dyakov
e03396ebac lock inside the listeners collection 2025-10-15 19:14:10 +03:00
Nedyalko Dyakov
e7dc339478 add Used to clarify the state of the conn 2025-10-15 18:44:10 +03:00
Nedyalko Dyakov
1bbf2e6781 few small improvements 2025-10-15 15:43:17 +03:00
Nedyalko Dyakov
07283ecfc6 add design decision comment 2025-10-15 14:51:18 +03:00
Nedyalko Dyakov
90bfdb3aa3 better conn usable timeout 2025-10-14 23:06:55 +03:00
Nedyalko Dyakov
8a629fb5a7 fix race in tests 2025-10-14 22:45:37 +03:00
Nedyalko Dyakov
d39da69f52 fix credListeners map 2025-10-14 21:18:52 +03:00
Nedyalko Dyakov
5fe0bfa0ff fix(pool): wip, pool reauth should not interfere with handoff 2025-10-14 21:06:40 +03:00
Nedyalko Dyakov
75ddeb3d5a feat(e2e-testing): maintnotifications e2e and refactor (#3526) 
* e2e wip

* cleanup

* remove unused fault injector mock

* errChan in test

* remove log messages tests

* cleanup log messages

* s/hitless/maintnotifications/

* fix moving when none

* better logs

* test with second client after action has started

* Fixes

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Test fix

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* feat(e2e-test): Extended e2e tests

* imroved e2e test resiliency

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>
Co-authored-by: Elena Kolevska <elena@kolevska.com>
Co-authored-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
Co-authored-by: Hristo Temelski <hristo.temelski@redis.com>
 2025-09-26 19:17:09 +03:00
cxljs
113a18ae75 fix: pipeline repeatedly sets the error (#3525) 
* fix: pipeline repeatedly sets the error

Signed-off-by: Xiaolong Chen <fukua95@gmail.com>

* add test

Signed-off-by: Xiaolong Chen <fukua95@gmail.com>

* CI

Signed-off-by: Xiaolong Chen <fukua95@gmail.com>

---------

Signed-off-by: Xiaolong Chen <fukua95@gmail.com>
Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
 2025-09-17 17:32:24 +03:00
Nedyalko Dyakov
0ef6d0727d feat: RESP3 notifications support & Hitless notifications handling [CAE-1088] & [CAE-1072] (#3418) 
- Adds support for handling push notifications with RESP3. 
- Using this support adds handlers for hitless upgrades.

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Hristo Temelski <hristo.temelski@redis.com>
 2025-09-10 22:18:01 +03:00
Nedyalko Dyakov
a264ffb8a4 fix: SetErr on Cmd if the command cannot be queued correctly in multi/exec (#3509) 
* set error if queued fails

* try fix for cluster

* add errors to cmds in pipeline if about to be returned
 2025-09-09 18:45:37 +03:00
cxljs
375fa5d083 chore(doc): improve code readability (#3446) 
- replace two similar functions `appendUniqueNode` and `appendIfNotExists` with a generic function.

- simplify the implementation of the `get` method in `clusterNodes`

- keep the member name `_generation` of `clusterNodes` consistent with other types.

- rename a data member `_masterAddr` to `masterAddr`.

Signed-off-by: Xiaolong Chen <fukua95@gmail.com>
 2025-08-04 17:22:16 +03:00
cxljs
82b00cc520 chore: remove a redundant method (#3401) 
Signed-off-by: fukua95 <fukua95@gmail.com>
Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
 2025-06-16 16:55:23 +03:00
Nedyalko Dyakov
86d418f940 feat: Introducing StreamingCredentialsProvider for token based authentication (#3320) 
* wip

* update documentation

* add streamingcredentialsprovider in options

* fix: put back option in pool creation

* add package level comment

* Initial re authentication implementation

Introduces the StreamingCredentialsProvider as the CredentialsProvider
with the highest priority.

TODO: needs to be tested

* Change function type name

Change CancelProviderFunc to UnsubscribeFunc

* add tests

* fix race in tests

* fix example tests

* wip, hooks refactor

* fix build

* update README.md

* update wordlist

* update README.md

* refactor(auth): early returns in cred listener

* fix(doctest): simulate some delay

* feat(conn): add close hook on conn

* fix(tests): simulate start/stop in mock credentials provider

* fix(auth): don't double close the conn

* docs(README): mark streaming credentials provider as experimental

* fix(auth): streamline auth err proccess

* fix(auth): check err on close conn

* chore(entraid): use the repo under redis org
 2025-05-27 16:25:20 +03:00
fukua95
28a3c97409 chore: set the default value for the options.protocol in the init() of options (#3387) 
* chore: set the default value for the `options.protocol` in the `init()` of `options`

Signed-off-by: fukua95 <fukua95@gmail.com>

* add a test

Signed-off-by: fukua95 <fukua95@gmail.com>

---------

Signed-off-by: fukua95 <fukua95@gmail.com>
 2025-05-27 14:53:41 +03:00
Nedyalko Dyakov
d54e848055 feat(options): panic when options are nil (#3363) 
Client creation should panic when options are nil.
 2025-04-30 09:33:40 +03:00
Nedyalko Dyakov
d236865b0c fix: handle network error on SETINFO (#3295) (CVE-2025-29923) 
* fix: handle network error on SETINFO

This fix addresses potential out of order responses as described in `CVE-2025-29923`

* fix: deprecate DisableIndentity and introduce DisableIdentity

Both options will work before V10. In v10 DisableIndentity will be dropped. The preferred flag to use is `DisableIdentity`.
 2025-03-19 19:02:36 +02:00
LINKIWI
1c9309fdc2 Set client name in HELLO RESP handshake (#3294) 2025-03-13 14:55:28 +02:00
LINKIWI
9db1286414 Reinstate read-only lock on hooks access in dialHook (#3225) 2025-02-11 17:50:31 +02:00
LINKIWI
080e051124 Eliminate redundant dial mutex causing unbounded connection queue contention (#3088) 
* Eliminate redundant dial mutex causing unbounded connection queue contention

* Dialer connection timeouts unit test

---------

Co-authored-by: ofekshenawa <104765379+ofekshenawa@users.noreply.github.com>
 2024-11-20 13:38:06 +02:00
ofekshenawa
04005cbdc7 Support Resp 3 Redis Search Unstable Mode (#3098) 
* Updated module version that points to retracted package version (#3074)

* Updated module version that points to retracted package version

* Updated testing image to latest

* support raw parsing for problematic Redis Search types

* Add UnstableResp3SearchModule to client options

* Add tests for Resp3 Search unstable mode

* Add tests for Resp3 Search unstable mode

* Add readme note

* Add words to spellcheck

* Add UnstableResp3SearchModule check to assertStableCommand

* Fix assertStableCommand logic

* remove go.mod changes

* Check panic occur on tests

* rename method

* update errors

* Rename flag to UnstableResp3

---------

Co-authored-by: Vladyslav Vildanov <117659936+vladvildanov@users.noreply.github.com>
Co-authored-by: vladvildanov <divinez122@outlook.com>
 2024-09-12 11:26:10 +03:00
Monkey
2d8fa02ac2 fix: fix #2681 (#2998) 
Signed-off-by: monkey92t <golang@88.com>
 2024-05-29 10:55:28 +08:00
ofekshenawa
5da49b1aba bug: Fix SETINFO ensuring it is set-and-forget (#2915) 
* Exexcute set-info without validation

* Fix tests

* Remove spaces from runtime.Version

* fix typo

* Send setinfo after auth

* Add pipline

* fix golangci

* revert fixing typo

* support sentinel
 2024-02-20 17:34:35 +02:00
ofekshenawa
35de49a8da Speed up connections by sending SetInfo via a pipeline (#2880) 
* Send Client SetInfo via pipe

* Fix ACL test

* Add client set info to acl command rules
 2024-02-15 12:48:56 +02:00
Tiago Peczenyj
21ed15bbed Add helpers to set libinfo without panic (#2724) 
* add helpers to set library name and library info without risk of panic if we try to set both

* refactor code to use helpers

* add example

* refactor tests

* fix testable example

* simplify example

* rename exampl

* fix ring.go

* update example

---------

Co-authored-by: ofekshenawa <104765379+ofekshenawa@users.noreply.github.com>
 2024-02-14 22:40:20 +02:00
ofekshenawa
a32be3d93d Add Suffix support to default client set info (#2852) 
* Add Suffix support to defualt client set info

* Change ClientNameSuffix to IdentitySuffix

* add tests
 2024-01-04 14:40:14 +02:00
RyoMiyashita
a109302230 fix: #2730 data race at hooksMixin (#2814) 2023-12-10 12:04:13 +02:00
ofekshenawa
0b6be62b71 Identify client on connect (#2708) 
* Update CLIENT-SETINFO to support suffixes

* Update CLIENT-SETINFO

* fix acl log test

* add setinfo option to cluster

* change to DisableIndentity

* change to DisableIndentity
 2023-09-20 10:33:09 +03:00
ljun20160606
391798880c feat: add protocol option (#2598) 2023-05-16 22:02:22 +08:00
Monkey
7b4f2179cb feat: no longer verify HELLO error messages (#2515) 
Signed-off-by: monkey92t <golang@88.com>
 2023-04-12 20:35:32 +08:00
Euclid
30a6f7107e fixed #2462 v9 continue support dragonfly, it's Hello command return "NOAUTH Authentication required" error (#2479) 
* fixed #2462 error NOAUTH and support dragonfly

* check add comment

* alignment

---------

Co-authored-by: Monkey <golang@88.com>
 2023-03-10 21:21:24 +08:00
monkey92t
21e1954745 fix(conn): releaseConn should be executed correctly 
Signed-off-by: monkey92t <golang@88.com>
 2023-01-28 15:44:06 +08:00
Vladimir Mihailenco
97b491aace chore: update import path 2023-01-23 08:48:54 +02:00
Vladimir Mihailenco
767109c632 chore: cleanup names 2023-01-21 10:30:02 +02:00
monkey
a5aeb1659b docs: update hook doc 
Signed-off-by: monkey <golang@88.com>
 2023-01-21 00:20:50 +08:00
monkey
0ed4a4420f fix: fix the withHook func 
Signed-off-by: monkey <golang@88.com>
 2023-01-21 00:02:44 +08:00
monkey
97697f488f feat: hook mode is changed to FIFO 
Signed-off-by: monkey <golang@88.com>
 2023-01-20 23:19:49 +08:00
monkey92t
d42dd1007c docs: add a description of the hook 
Signed-off-by: monkey92t <golang@88.com>
 2023-01-07 16:30:56 +08:00
Monkey
c7bc54b4d0 Merge pull request #2333 from monkey92t/fix_2312 
feat: add ClientName option
 2022-12-28 22:31:25 +08:00
monkey92t
a872c35b1a feat: add ClientName option 
Signed-off-by: monkey92t <golang@88.com>
 2022-12-28 22:14:52 +08:00
Monkey
a4336cbd43 feat(scan): add Scanner interface (#2317) 
Signed-off-by: monkey92t <golang@88.com>
 2022-12-24 22:29:45 +08:00
Vladimir Mihailenco
5053db2f9c fix: wrap cmds in Conn.TxPipeline 2022-11-22 14:30:27 +02:00
Dom Parfitt
d1bfaba549 fix: capture error correctly in withConn 2022-11-02 09:11:36 +00:00