redis/go-redis
1
0
Fork 0
mirror of https://github.com/redis/go-redis.git synced 2025-07-18 00:20:57 +03:00
Code Activity

Revert "ConnPool check fd for bad conns (#1824)" (#1849)

Browse Source 
This reverts commit 346bfafddd.
This commit is contained in:
monkey92t
2021-08-06 17:16:22 +08:00
committed by GitHub
parent 67ae445d24
commit fd3025bfed
10 changed files with 18 additions and 204 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tx_test.go
View File

@ -123,7 +123,7 @@ var _ = Describe("Tx", func() {
Expect(num).To(Equal(int64(N)))
})
It("should remove from bad connection", func() {
It("should recover from bad connection", func() {
// Put bad connection in the pool.
cn, err := client.Pool().Get(context.Background())
Expect(err).NotTo(HaveOccurred())
@ -134,14 +134,17 @@ var _ = Describe("Tx", func() {
do := func() error {
err := client.Watch(ctx, func(tx *redis.Tx) error {
_, err := tx.TxPipelined(ctx, func(pipe redis.Pipeliner) error {
return pipe.Ping(ctx).Err()
pipe.Ping(ctx)
return nil
})
return err
})
return err
}
// connCheck will automatically remove damaged connections.
err = do()
Expect(err).To(MatchError("bad connection"))
err = do()
Expect(err).NotTo(HaveOccurred())
})