Cleanup pool

internal/pool/pool_sticky.go

@@ -28,55 +28,40 @@ func (p *StickyConnPool) CloseConn(*Conn) error {
 	panic("not implemented")
 }
 
-func (p *StickyConnPool) Get() (*Conn, bool, error) {
+func (p *StickyConnPool) Get() (*Conn, error) {
 	p.mu.Lock()
 	defer p.mu.Unlock()
 
 	if p.closed {
-		return nil, false, ErrClosed
+		return nil, ErrClosed
 	}
 	if p.cn != nil {
-		return p.cn, false, nil
+		return p.cn, nil
 	}
 
-	cn, _, err := p.pool.Get()
+	cn, err := p.pool.Get()
 	if err != nil {
-		return nil, false, err
+		return nil, err
 	}
+
 	p.cn = cn
-	return cn, true, nil
+	return cn, nil
 }
 
-func (p *StickyConnPool) putUpstream() (err error) {
-	err = p.pool.Put(p.cn)
+func (p *StickyConnPool) putUpstream() {
+	p.pool.Put(p.cn)
 	p.cn = nil
-	return err
 }
 
-func (p *StickyConnPool) Put(cn *Conn) error {
-	p.mu.Lock()
-	defer p.mu.Unlock()
+func (p *StickyConnPool) Put(cn *Conn) {}
 
-	if p.closed {
-		return ErrClosed
-	}
-	return nil
-}
-
-func (p *StickyConnPool) removeUpstream() error {
-	err := p.pool.Remove(p.cn)
+func (p *StickyConnPool) removeUpstream() {
+	p.pool.Remove(p.cn)
 	p.cn = nil
-	return err
 }
 
-func (p *StickyConnPool) Remove(cn *Conn) error {
-	p.mu.Lock()
-	defer p.mu.Unlock()
-
-	if p.closed {
-		return nil
-	}
-	return p.removeUpstream()
+func (p *StickyConnPool) Remove(cn *Conn) {
+	p.removeUpstream()
 }
 
 func (p *StickyConnPool) Len() int {
@@ -89,7 +74,7 @@ func (p *StickyConnPool) Len() int {
 	return 1
 }
 
-func (p *StickyConnPool) FreeLen() int {
+func (p *StickyConnPool) IdleLen() int {
 	p.mu.Lock()
 	defer p.mu.Unlock()
 
@@ -111,13 +96,14 @@ func (p *StickyConnPool) Close() error {
 		return ErrClosed
 	}
 	p.closed = true
-	var err error
+
 	if p.cn != nil {
 		if p.reusable {
-			err = p.putUpstream()
+			p.putUpstream()
 		} else {
-			err = p.removeUpstream()
+			p.removeUpstream()
 		}
 	}
-	return err
+
+	return nil
 }