redis/go-redis
1
0
Fork 0
mirror of https://github.com/redis/go-redis.git synced 2025-12-02 06:22:31 +03:00
Code Activity

add comments

Browse Source
This commit is contained in:
Nedyalko Dyakov
2025-10-26 00:50:09 +03:00
parent b2225f165b
commit f52ab34e31
2 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
internal/pool/conn.go
View File

@@ -664,14 +664,17 @@ func (cn *Conn) GetStateMachine() *ConnStateMachine {
// TryAcquire attempts to acquire the connection for use. // TryAcquire attempts to acquire the connection for use.
// This is an optimized inline method for the hot path (Get operation). // This is an optimized inline method for the hot path (Get operation).
// //
// It tries to transition from IDLE → IN_USE or CREATED → IN_USE. // It tries to transition from IDLE -> IN_USE or CREATED -> IN_USE.
// Returns true if the connection was successfully acquired, false otherwise. // Returns true if the connection was successfully acquired, false otherwise.
// //
// Performance: This is faster than calling GetStateMachine() + TryTransitionFast() // Performance: This is faster than calling GetStateMachine() + TryTransitionFast()
// because it avoids the extra pointer dereference and allows better inlining. //
// NOTE: We directly access cn.stateMachine.state here instead of using the state machine's
// methods. This breaks encapsulation but is necessary for performance.
// The IDLE->IN_USE and CREATED->IN_USE transitions don't need
// waiter notification, and benchmarks show 1-3% improvement. If the state machine ever
// needs to notify waiters on these transitions, update this to use TryTransitionFast().
func (cn *Conn) TryAcquire() bool { func (cn *Conn) TryAcquire() bool {
// Inline the hot path - try IDLE → IN_USE first (most common case)
// Then try CREATED → IN_USE (new connections)
// The || operator short-circuits, so only 1 CAS in the common case // The || operator short-circuits, so only 1 CAS in the common case
return cn.stateMachine.state.CompareAndSwap(uint32(StateIdle), uint32(StateInUse)) || return cn.stateMachine.state.CompareAndSwap(uint32(StateIdle), uint32(StateInUse)) ||
cn.stateMachine.state.CompareAndSwap(uint32(StateCreated), uint32(StateInUse)) cn.stateMachine.state.CompareAndSwap(uint32(StateCreated), uint32(StateInUse))
@@ -680,11 +683,15 @@ func (cn *Conn) TryAcquire() bool {
// Release releases the connection back to the pool. // Release releases the connection back to the pool.
// This is an optimized inline method for the hot path (Put operation). // This is an optimized inline method for the hot path (Put operation).
// //
// It tries to transition from IN_USE → IDLE. // It tries to transition from IN_USE -> IDLE.
// Returns true if the connection was successfully released, false otherwise. // Returns true if the connection was successfully released, false otherwise.
// //
// Performance: This is faster than calling GetStateMachine() + TryTransitionFast() // Performance: This is faster than calling GetStateMachine() + TryTransitionFast().
// because it avoids the extra pointer dereference and allows better inlining. //
// NOTE: We directly access cn.stateMachine.state here instead of using the state machine's
// methods. This breaks encapsulation but is necessary for performance.
// If the state machine ever needs to notify waiters
// on this transition, update this to use TryTransitionFast().
func (cn *Conn) Release() bool { func (cn *Conn) Release() bool {
// Inline the hot path - single CAS operation // Inline the hot path - single CAS operation
return cn.stateMachine.state.CompareAndSwap(uint32(StateInUse), uint32(StateIdle)) return cn.stateMachine.state.CompareAndSwap(uint32(StateInUse), uint32(StateIdle))

4
internal/pool/pool.go
View File

@@ -286,7 +286,7 @@ func (p *ConnPool) newConn(ctx context.Context, pooled bool) (*Conn, error) {
return nil, ErrClosed return nil, ErrClosed
} }
if p.cfg.MaxActiveConns > 0 && p.poolSize.Load() >= int32(p.cfg.MaxActiveConns) { if p.cfg.MaxActiveConns > 0 && p.poolSize.Load() >= p.cfg.MaxActiveConns {
return nil, ErrPoolExhausted return nil, ErrPoolExhausted
} }
@@ -301,7 +301,7 @@ func (p *ConnPool) newConn(ctx context.Context, pooled bool) (*Conn, error) {
// when first used. Do NOT transition to IDLE here - that happens after initialization completes. // when first used. Do NOT transition to IDLE here - that happens after initialization completes.
// The state machine flow is: CREATED → INITIALIZING (in initConn) → IDLE (after init success) // The state machine flow is: CREATED → INITIALIZING (in initConn) → IDLE (after init success)
if p.cfg.MaxActiveConns > 0 && p.poolSize.Load() > int32(p.cfg.MaxActiveConns) { if p.cfg.MaxActiveConns > 0 && p.poolSize.Load() > p.cfg.MaxActiveConns {
_ = cn.Close() _ = cn.Close()
return nil, ErrPoolExhausted return nil, ErrPoolExhausted
} }