mirror of
https://github.com/redis/go-redis.git
synced 2025-10-23 08:08:28 +03:00
add some comments
This commit is contained in:
@@ -39,10 +39,11 @@ func (m *Manager) Listener(
|
|||||||
connID := poolCn.GetID()
|
connID := poolCn.GetID()
|
||||||
// if we reconnect the underlying network connection, the streaming credentials listener will continue to work
|
// if we reconnect the underlying network connection, the streaming credentials listener will continue to work
|
||||||
// so we can get the old listener from the cache and use it.
|
// so we can get the old listener from the cache and use it.
|
||||||
|
|
||||||
// subscribing the same (an already subscribed) listener for a StreamingCredentialsProvider SHOULD be a no-op
|
// subscribing the same (an already subscribed) listener for a StreamingCredentialsProvider SHOULD be a no-op
|
||||||
listener, ok := m.credentialsListeners.Get(connID)
|
listener, ok := m.credentialsListeners.Get(connID)
|
||||||
if !ok || listener == nil {
|
if !ok || listener == nil {
|
||||||
|
// Create new listener for this connection
|
||||||
|
// Note: Callbacks (reAuth, onErr) are captured once and reused for the connection's lifetime
|
||||||
newCredListener := &ConnReAuthCredentialsListener{
|
newCredListener := &ConnReAuthCredentialsListener{
|
||||||
conn: poolCn,
|
conn: poolCn,
|
||||||
reAuth: reAuth,
|
reAuth: reAuth,
|
||||||
|
|||||||
@@ -79,6 +79,8 @@ func (r *ReAuthPoolHook) OnPut(_ context.Context, conn *pool.Conn) (bool, bool,
|
|||||||
r.shouldReAuthLock.RUnlock()
|
r.shouldReAuthLock.RUnlock()
|
||||||
|
|
||||||
if ok {
|
if ok {
|
||||||
|
// Acquire both locks to atomically move from shouldReAuth to scheduledReAuth
|
||||||
|
// This prevents race conditions where OnGet might miss the transition
|
||||||
r.shouldReAuthLock.Lock()
|
r.shouldReAuthLock.Lock()
|
||||||
r.scheduledLock.Lock()
|
r.scheduledLock.Lock()
|
||||||
r.scheduledReAuth[connID] = true
|
r.scheduledReAuth[connID] = true
|
||||||
|
|||||||
@@ -5,6 +5,9 @@ import (
|
|||||||
"time"
|
"time"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
// SingleConnPool is a pool that always returns the same connection.
|
||||||
|
// Note: This pool is not thread-safe.
|
||||||
|
// It is intended to be used by clients that need a single connection.
|
||||||
type SingleConnPool struct {
|
type SingleConnPool struct {
|
||||||
pool Pooler
|
pool Pooler
|
||||||
cn *Conn
|
cn *Conn
|
||||||
@@ -13,6 +16,12 @@ type SingleConnPool struct {
|
|||||||
|
|
||||||
var _ Pooler = (*SingleConnPool)(nil)
|
var _ Pooler = (*SingleConnPool)(nil)
|
||||||
|
|
||||||
|
// NewSingleConnPool creates a new single connection pool.
|
||||||
|
// The pool will always return the same connection.
|
||||||
|
// The pool will not:
|
||||||
|
// - Close the connection
|
||||||
|
// - Reconnect the connection
|
||||||
|
// - Track the connection in any way
|
||||||
func NewSingleConnPool(pool Pooler, cn *Conn) *SingleConnPool {
|
func NewSingleConnPool(pool Pooler, cn *Conn) *SingleConnPool {
|
||||||
return &SingleConnPool{
|
return &SingleConnPool{
|
||||||
pool: pool,
|
pool: pool,
|
||||||
|
|||||||
Reference in New Issue
Block a user