redis/go-redis
1
0
Fork 0
mirror of https://github.com/redis/go-redis.git synced 2025-07-18 00:20:57 +03:00
Code Activity

feat: remove global handlers and enable push notifications by default

Browse Source 
- Remove all global push notification handler functionality
- Simplify registry to support only single handler per notification type
- Enable push notifications by default for RESP3 connections
- Update comprehensive test suite to remove global handler tests
- Update demo to show multiple specific handlers instead of global handlers
- Always respect custom processors regardless of PushNotifications flag

Push notifications are now automatically enabled for RESP3 and each
notification type has a single dedicated handler for predictable behavior.
This commit is contained in:
Nedyalko Dyakov
2025-06-26 21:03:19 +03:00
parent 1ff0ded0e3
commit e6e2cead66
5 changed files with 51 additions and 213 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
redis.go
View File

@ -755,6 +755,12 @@ func NewClient(opt *Options) *Client {
}
opt.init()
// Enable push notifications by default for RESP3
// Only override if no custom processor is provided
if opt.Protocol == 3 && opt.PushNotificationProcessor == nil {
opt.PushNotifications = true
}
c := Client{
baseClient: &baseClient{
opt: opt,
@ -803,13 +809,12 @@ func (c *Client) Options() *Options {
// initializePushProcessor initializes the push notification processor.
func (c *Client) initializePushProcessor() {
// Initialize push processor if enabled
if c.opt.PushNotifications {
if c.opt.PushNotificationProcessor != nil {
c.pushProcessor = c.opt.PushNotificationProcessor
} else {
c.pushProcessor = NewPushNotificationProcessor(true)
}
// Always use custom processor if provided
if c.opt.PushNotificationProcessor != nil {
c.pushProcessor = c.opt.PushNotificationProcessor
} else if c.opt.PushNotifications {
// Create default processor only if push notifications are enabled
c.pushProcessor = NewPushNotificationProcessor(true)
}
}
@ -822,13 +827,6 @@ func (c *Client) RegisterPushNotificationHandler(command string, handler PushNot
return nil
}
// RegisterGlobalPushNotificationHandler registers a handler that will receive all push notifications.
func (c *Client) RegisterGlobalPushNotificationHandler(handler PushNotificationHandler) {
if c.pushProcessor != nil {
c.pushProcessor.RegisterGlobalHandler(handler)
}
}
// RegisterPushNotificationHandlerFunc registers a function as a handler for a specific push notification command.
// Returns an error if a handler is already registered for this command.
func (c *Client) RegisterPushNotificationHandlerFunc(command string, handlerFunc func(ctx context.Context, notification []interface{}) bool) error {
@ -838,13 +836,6 @@ func (c *Client) RegisterPushNotificationHandlerFunc(command string, handlerFunc
return nil
}
// RegisterGlobalPushNotificationHandlerFunc registers a function as a global handler for all push notifications.
func (c *Client) RegisterGlobalPushNotificationHandlerFunc(handlerFunc func(ctx context.Context, notification []interface{}) bool) {
if c.pushProcessor != nil {
c.pushProcessor.RegisterGlobalHandlerFunc(handlerFunc)
}
}
// GetPushNotificationProcessor returns the push notification processor.
func (c *Client) GetPushNotificationProcessor() *PushNotificationProcessor {
return c.pushProcessor