redis/go-redis
1
0
Fork 0
mirror of https://github.com/redis/go-redis.git synced 2025-12-05 06:22:07 +03:00
Code Activity

feat(otel): categorize metrics with nil response (#3638)

Browse Source 
* Remove metrics with empty data

Because empty data cannot be considered an error.

* redis.Nil uses a separate state.

Better differentiation between values, null values, and errors.
This commit is contained in:
fengwei
2025-12-03 22:41:44 +08:00
committed by GitHub
parent eeea45c8f8
commit e2153f5c16
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extra/redisotel/metrics.go
View File

@@ -330,6 +330,9 @@ func milliseconds(d time.Duration) float64 {
func statusAttr(err error) attribute.KeyValue { func statusAttr(err error) attribute.KeyValue {
if err != nil { if err != nil {
if err == redis.Nil {
return attribute.String("status", "nil")
}
return attribute.String("status", "error") return attribute.String("status", "error")
} }
return attribute.String("status", "ok") return attribute.String("status", "ok")