redis/go-redis
1
0
Fork 0
mirror of https://github.com/redis/go-redis.git synced 2025-07-28 06:42:00 +03:00
Code Activity

Merge pull request #1484 from go-redis/fix/cluster-node-latency

Browse Source 
Periodically update Cluster node latency
This commit is contained in:
Vladimir Mihailenco
2020-09-11 14:29:38 +03:00
committed by GitHub
parent 68baad7f84 46e04ce67e
commit afb0064872
2 changed files with 183 additions and 178 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
cluster.go
View File

@ -193,16 +193,19 @@ func (n *clusterNode) Close() error {
}
func (n *clusterNode) updateLatency() {
const probes = 10
const numProbe = 10
var dur uint64
for i := 0; i < numProbe; i++ {
time.Sleep(time.Duration(10+rand.Intn(10)) * time.Millisecond)
var latency uint32
for i := 0; i < probes; i++ {
start := time.Now()
n.Client.Ping(context.TODO())
probe := uint32(time.Since(start) / time.Microsecond)
latency = (latency + probe) / 2
dur += uint64(time.Since(start) / time.Microsecond)
}
atomic.StoreUint32(&n.latency, latency)
latency := float64(dur) / float64(numProbe)
atomic.StoreUint32(&n.latency, uint32(latency+0.5))
}
func (n *clusterNode) Latency() time.Duration {
@ -323,6 +326,9 @@ func (c *clusterNodes) GC(generation uint32) {
for addr, node := range c.nodes {
if node.Generation() >= generation {
c.activeAddrs = append(c.activeAddrs, addr)
if c.opt.RouteByLatency {
go node.updateLatency()
}
continue
}
@ -553,8 +559,6 @@ func (c *clusterState) slotSlaveNode(slot int) (*clusterNode, error) {
}
func (c *clusterState) slotClosestNode(slot int) (*clusterNode, error) {
const threshold = time.Millisecond
nodes := c.slotNodes(slot)
if len(nodes) == 0 {
return c.nodes.Random()
@ -565,13 +569,14 @@ func (c *clusterState) slotClosestNode(slot int) (*clusterNode, error) {
if n.Failing() {
continue
}
if node == nil || node.Latency()-n.Latency() > threshold {
if node == nil || n.Latency() < node.Latency() {
node = n
}
}
if node != nil {
return node, nil
}
// If all nodes are failing - return random node
return c.nodes.Random()
}