redis/go-redis
1
0
Fork 0
mirror of https://github.com/redis/go-redis.git synced 2025-04-17 20:17:02 +03:00
Code

feat: support Elasticache cluster mode by introducing IsClusterMode config param (#3255)

Browse Source 
Co-authored-by: Rushikesh Joshi <rushikesh.joshi@sap.com>
Co-authored-by: Nedyalko Dyakov <nedyalko.dyakov@gmail.com>
This commit is contained in:
Rushikesh Joshi 2025-02-26 08:25:55 -08:00 committed by GitHub
parent d4e74b125d
commit 7d55118554
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
universal.go
View File

@ -69,6 +69,9 @@ type UniversalOptions struct {
DisableIndentity bool DisableIndentity bool
IdentitySuffix string IdentitySuffix string
UnstableResp3 bool UnstableResp3 bool
// IsClusterMode can be used when only one Addrs is provided (e.g. Elasticache supports setting up cluster mode with configuration endpoint).
IsClusterMode bool
} }
// Cluster returns cluster options created from the universal options. // Cluster returns cluster options created from the universal options.
@ -244,7 +247,7 @@ var (
func NewUniversalClient(opts *UniversalOptions) UniversalClient { func NewUniversalClient(opts *UniversalOptions) UniversalClient {
if opts.MasterName != "" { if opts.MasterName != "" {
return NewFailoverClient(opts.Failover()) return NewFailoverClient(opts.Failover())
} else if len(opts.Addrs) > 1 { } else if len(opts.Addrs) > 1 || opts.IsClusterMode {
return NewClusterClient(opts.Cluster()) return NewClusterClient(opts.Cluster())
} }
return NewClient(opts.Simple()) return NewClient(opts.Simple())

17
universal_test.go
View File

@ -60,4 +60,21 @@ var _ = Describe("UniversalClient", func() {
a := func() { client.FTInfo(ctx, "all").Result() } a := func() { client.FTInfo(ctx, "all").Result() }
Expect(a).ToNot(Panic()) Expect(a).ToNot(Panic())
}) })
It("should connect to clusters if IsClusterMode is set even if only a single address is provided", Label("NonRedisEnterprise"), func() {
client = redis.NewUniversalClient(&redis.UniversalOptions{
Addrs: []string{cluster.addrs()[0]},
IsClusterMode: true,
})
_, ok := client.(*redis.ClusterClient)
Expect(ok).To(BeTrue(), "expected a ClusterClient")
})
It("should return all slots after instantiating UniversalClient with IsClusterMode", Label("NonRedisEnterprise"), func() {
client = redis.NewUniversalClient(&redis.UniversalOptions{
Addrs: []string{cluster.addrs()[0]},
IsClusterMode: true,
})
Expect(client.ClusterSlots(ctx).Val()).To(HaveLen(3))
})
}) })