redis/go-redis
1
0
Fork 0
mirror of https://github.com/redis/go-redis.git synced 2025-12-25 00:01:00 +03:00
Code Activity

feat(otel): add trace filter for process pipeline and dial operation (#3550)

Browse Source 
* feat(tracing): add process pipeline and dial filtering options for tracing

* refactor(tracing): implement default command filter and process pipeline options

* refactor(tracing): rename defaultCommandFilter to DefaultCommandFilter

* refactor(tracing): add BasicCommandFilter as a deprecated alias for DefaultCommandFilter

---------

Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
This commit is contained in:
Udhayarajan
2025-10-22 15:27:15 +05:30
committed by GitHub
parent a15e76394c
commit 70dfa383fe
3 changed files with 167 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
extra/redisotel/tracing.go
View File

@@ -87,6 +87,11 @@ func newTracingHook(connString string, opts ...TracingOption) *tracingHook {
func (th *tracingHook) DialHook(hook redis.DialHook) redis.DialHook {
return func(ctx context.Context, network, addr string) (net.Conn, error) {
if th.conf.filterDial {
return hook(ctx, network, addr)
}
ctx, span := th.conf.tracer.Start(ctx, "redis.dial", th.spanOpts...)
defer span.End()
@@ -103,7 +108,7 @@ func (th *tracingHook) ProcessHook(hook redis.ProcessHook) redis.ProcessHook {
return func(ctx context.Context, cmd redis.Cmder) error {
// Check if the command should be filtered out
if th.conf.filter != nil && th.conf.filter(cmd) {
if th.conf.filterProcess != nil && th.conf.filterProcess(cmd) {
// If so, just call the next hook
return hook(ctx, cmd)
}
@@ -141,6 +146,11 @@ func (th *tracingHook) ProcessPipelineHook(
hook redis.ProcessPipelineHook,
) redis.ProcessPipelineHook {
return func(ctx context.Context, cmds []redis.Cmder) error {
if th.conf.filterProcessPipeline != nil && th.conf.filterProcessPipeline(cmds) {
return hook(ctx, cmds)
}
attrs := make([]attribute.KeyValue, 0, 8)
attrs = append(attrs,
attribute.Int("db.redis.num_cmd", len(cmds)),