chore(release): v9.17.0 (#3604)

* update release notes * update readme * update version number * cleanup release notes * fix checkMinIdle
2025-11-24 18:41:04 +03:00 · 2025-11-19 19:53:02 +02:00
parent 6c24f600de
commit 5b0b228a37
18 changed files with 273 additions and 58 deletions
--- a/.github/RELEASE_NOTES_TEMPLATE.md
+++ b/.github/RELEASE_NOTES_TEMPLATE.md
@@ -0,0 +1,125 @@
+# Release Notes Template for go-redis
+
+This template provides a structured format for creating release notes for go-redis releases.
+
+## Format Structure
+
+```markdown
+# X.Y.Z (YYYY-MM-DD)
+
+## 🚀 Highlights
+
+### [Category Name]
+Brief description of the major feature/change with context and impact.
+- Key points
+- Performance metrics if applicable
+- Links to documentation
+
+### [Another Category]
+...
+
+## ✨ New Features
+
+- Feature description ([#XXXX](https://github.com/redis/go-redis/pull/XXXX)) by [@username](https://github.com/username)
+- ...
+
+## 🐛 Bug Fixes
+
+- Fix description ([#XXXX](https://github.com/redis/go-redis/pull/XXXX)) by [@username](https://github.com/username)
+- ...
+
+## ⚡ Performance
+
+- Performance improvement description ([#XXXX](https://github.com/redis/go-redis/pull/XXXX)) by [@username](https://github.com/username)
+- ...
+
+## 🧪 Testing & Infrastructure
+
+- Testing/CI improvement ([#XXXX](https://github.com/redis/go-redis/pull/XXXX)) by [@username](https://github.com/username)
+- ...
+
+## 👥 Contributors
+
+We'd like to thank all the contributors who worked on this release!
+
+[@username1](https://github.com/username1), [@username2](https://github.com/username2), ...
+
+---
+
+**Full Changelog**: https://github.com/redis/go-redis/compare/vX.Y-1.Z...vX.Y.Z
+```
+
+## Guidelines
+
+### Highlights Section
+The Highlights section should contain the **most important** user-facing changes. Common categories include:
+
+- **Typed Errors** - Error handling improvements
+- **New Commands** - New Redis commands support (especially for new Redis versions)
+- **Search & Vector** - RediSearch and vector-related features
+- **Connection Pool** - Pool improvements and performance
+- **Metrics & Observability** - Monitoring and instrumentation
+- **Breaking Changes** - Any breaking changes (should be prominent)
+
+Each highlight should:
+- Have a descriptive title
+- Include context about why it matters
+- Link to relevant PRs
+- Include performance metrics if applicable
+
+### New Features Section
+- List all new features with PR links and contributor attribution
+- Use descriptive text, not just PR titles
+- Group related features together if it makes sense
+
+### Bug Fixes Section
+- Only include actual bug fixes
+- Be specific about what was broken and how it's fixed
+- Include issue links if the PR references an issue
+
+### Performance Section
+- Separate from New Features to highlight performance work
+- Include metrics when available (e.g., "47-67% faster", "33% less memory")
+- Explain the impact on users
+
+### Testing & Infrastructure Section
+- Include only important testing/CI changes
+- **Exclude** dependency bumps (e.g., dependabot PRs for actions)
+- **Exclude** minor CI tweaks unless they're significant
+- Include major Redis version updates in CI
+
+### What to Exclude
+- Dependency bumps (dependabot PRs)
+- Minor documentation typo fixes
+- Internal refactoring that doesn't affect users
+- Duplicate entries (same PR in multiple sections)
+- `dependabot[bot]` from contributors list
+
+### Formatting Rules
+1. **PR Links**: Use `([#XXXX](https://github.com/redis/go-redis/pull/XXXX))` format
+2. **Contributor Links**: Use `[@username](https://github.com/username)` format
+3. **Issue Links**: Use `([#XXXX](https://github.com/redis/go-redis/issues/XXXX))` format
+4. **Full Changelog**: Always include at the bottom with correct version comparison
+
+### Getting PR Information
+Use GitHub API to fetch PR details:
+```bash
+# Get recent merged PRs
+gh pr list --state merged --limit 50 --json number,title,author,mergedAt,url
+```
+
+Or use the GitHub web interface to review merged PRs between releases.
+
+### Example Workflow
+1. Gather all merged PRs since last release
+2. Categorize PRs by type (feature, bug fix, performance, etc.)
+3. Identify the 3-5 most important changes for Highlights
+4. Remove duplicates and dependency bumps
+5. Add PR and contributor links
+6. Review for clarity and completeness
+7. Add Full Changelog link with correct version tags
+
+## Example (v9.17.0)
+
+See the v9.17.0 release notes in `RELEASE-NOTES.md` for a complete example following this template.
+
--- a/README.md
+++ b/README.md
@@ -2,7 +2,7 @@

 [![build workflow](https://github.com/redis/go-redis/actions/workflows/build.yml/badge.svg)](https://github.com/redis/go-redis/actions)
 [![PkgGoDev](https://pkg.go.dev/badge/github.com/redis/go-redis/v9)](https://pkg.go.dev/github.com/redis/go-redis/v9?tab=doc)
-[![Documentation](https://img.shields.io/badge/redis-documentation-informational)](https://redis.uptrace.dev/)
+[![Documentation](https://img.shields.io/badge/redis-documentation-informational)](https://redis.io/docs/latest/develop/clients/go/)
 [![Go Report Card](https://goreportcard.com/badge/github.com/redis/go-redis/v9)](https://goreportcard.com/report/github.com/redis/go-redis/v9)
 [![codecov](https://codecov.io/github/redis/go-redis/graph/badge.svg?token=tsrCZKuSSw)](https://codecov.io/github/redis/go-redis)

@@ -17,15 +17,15 @@
 ## Supported versions

 In `go-redis` we are aiming to support the last three releases of Redis. Currently, this means we do support:
- [Redis 7.2](https://raw.githubusercontent.com/redis/redis/7.2/00-RELEASENOTES) - using Redis Stack 7.2 for modules support
- [Redis 7.4](https://raw.githubusercontent.com/redis/redis/7.4/00-RELEASENOTES) - using Redis Stack 7.4 for modules support
- [Redis 8.0](https://raw.githubusercontent.com/redis/redis/8.0/00-RELEASENOTES) - using Redis CE 8.0 where modules are included
- [Redis 8.2](https://raw.githubusercontent.com/redis/redis/8.2/00-RELEASENOTES) - using Redis CE 8.2 where modules are included
+- [Redis 8.0](https://raw.githubusercontent.com/redis/redis/8.0/00-RELEASENOTES) - using Redis CE 8.0
+- [Redis 8.2](https://raw.githubusercontent.com/redis/redis/8.2/00-RELEASENOTES) - using Redis CE 8.2 
+- [Redis 8.4](https://raw.githubusercontent.com/redis/redis/8.4/00-RELEASENOTES) - using Redis CE 8.4

 Although the `go.mod` states it requires at minimum `go 1.18`, our CI is configured to run the tests against all three
 versions of Redis and latest two versions of Go ([1.23](https://go.dev/doc/devel/release#go1.23.0),
 [1.24](https://go.dev/doc/devel/release#go1.24.0)). We observe that some modules related test may not pass with
 Redis Stack 7.2 and some commands are changed with Redis CE 8.0.
+Although it is not officially supported, `go-redis/v9`  should be able to work with any Redis 7.0+.
 Please do refer to the documentation and the tests if you experience any issues. We do plan to update the go version
 in the `go.mod` to `go 1.24` in one of the next releases.

@@ -43,10 +43,6 @@ in the `go.mod` to `go 1.24` in one of the next releases.

 [Work at Redis](https://redis.com/company/careers/jobs/)

-## Documentation
-
- [English](https://redis.uptrace.dev)
- [简体中文](https://redis.uptrace.dev/zh/)

 ## Resources

@@ -55,16 +51,18 @@ in the `go.mod` to `go 1.24` in one of the next releases.
 - [Reference](https://pkg.go.dev/github.com/redis/go-redis/v9)
 - [Examples](https://pkg.go.dev/github.com/redis/go-redis/v9#pkg-examples)

+## old documentation
+
+- [English](https://redis.uptrace.dev)
+- [简体中文](https://redis.uptrace.dev/zh/)
+
 ## Ecosystem

- [Redis Mock](https://github.com/go-redis/redismock)
+- [Entra ID (Azure AD)](https://github.com/redis/go-redis-entraid)
 - [Distributed Locks](https://github.com/bsm/redislock)
 - [Redis Cache](https://github.com/go-redis/cache)
 - [Rate limiting](https://github.com/go-redis/redis_rate)

-This client also works with [Kvrocks](https://github.com/apache/incubator-kvrocks), a distributed
-key value NoSQL database that uses RocksDB as storage engine and is compatible with Redis protocol.
-
 ## Features

 - Redis commands except QUIT and SYNC.
@@ -75,7 +73,6 @@ key value NoSQL database that uses RocksDB as storage engine and is compatible w
 - [Scripting](https://redis.uptrace.dev/guide/lua-scripting.html).
 - [Redis Sentinel](https://redis.uptrace.dev/guide/go-redis-sentinel.html).
 - [Redis Cluster](https://redis.uptrace.dev/guide/go-redis-cluster.html).
- [Redis Ring](https://redis.uptrace.dev/guide/ring.html).
 - [Redis Performance Monitoring](https://redis.uptrace.dev/guide/redis-performance-monitoring.html).
 - [Redis Probabilistic [RedisStack]](https://redis.io/docs/data-types/probabilistic/)
 - [Customizable read and write buffers size.](#custom-buffer-sizes)
--- a/RELEASE-NOTES.md
+++ b/RELEASE-NOTES.md
@@ -1,5 +1,79 @@
 # Release Notes

+# 9.17.0 (2025-11-19)
+
+## 🚀 Highlights
+
+### Redis 8.4 Support
+Added support for Redis 8.4, including new commands and features ([#3572](https://github.com/redis/go-redis/pull/3572))
+
+### Typed Errors
+Introduced typed errors for better error handling using `errors.As` instead of string checks. Errors can now be wrapped and set to commands in hooks without breaking library functionality ([#3602](https://github.com/redis/go-redis/pull/3602))
+
+### New Commands
+- **CAS/CAD Commands**: Added support for Compare-And-Set/Compare-And-Delete operations with conditional matching (`IFEQ`, `IFNE`, `IFDEQ`, `IFDNE`) ([#3583](https://github.com/redis/go-redis/pull/3583), [#3595](https://github.com/redis/go-redis/pull/3595))
+- **MSETEX**: Atomically set multiple key-value pairs with expiration options and conditional modes ([#3580](https://github.com/redis/go-redis/pull/3580))
+- **XReadGroup CLAIM**: Consume both incoming and idle pending entries from streams in a single call ([#3578](https://github.com/redis/go-redis/pull/3578))
+- **ACL Commands**: Added `ACLGenPass`, `ACLUsers`, and `ACLWhoAmI` ([#3576](https://github.com/redis/go-redis/pull/3576))
+- **SLOWLOG Commands**: Added `SLOWLOG LEN` and `SLOWLOG RESET` ([#3585](https://github.com/redis/go-redis/pull/3585))
+- **LATENCY Commands**: Added `LATENCY LATEST` and `LATENCY RESET` ([#3584](https://github.com/redis/go-redis/pull/3584))
+
+### Search & Vector Improvements
+- **Hybrid Search**: Added  **EXPERIMENTAL** support for the new `FT.HYBRID` command ([#3573](https://github.com/redis/go-redis/pull/3573))
+- **Vector Range**: Added `VRANGE` command for vector sets ([#3543](https://github.com/redis/go-redis/pull/3543))
+- **FT.INFO Enhancements**: Added vector-specific attributes in FT.INFO response ([#3596](https://github.com/redis/go-redis/pull/3596))
+
+### Connection Pool Improvements
+- **Improved Connection Success Rate**: Implemented FIFO queue-based fairness and context pattern for connection creation to prevent premature cancellation under high concurrency ([#3518](https://github.com/redis/go-redis/pull/3518))
+- **Connection State Machine**: Resolved race conditions and improved pool performance with proper state tracking ([#3559](https://github.com/redis/go-redis/pull/3559))
+- **Pool Performance**: Significant performance improvements with faster semaphores, lockless hook manager, and reduced allocations (47-67% faster Get/Put operations) ([#3565](https://github.com/redis/go-redis/pull/3565))
+
+### Metrics & Observability
+- **Canceled Metric Attribute**: Added 'canceled' metrics attribute to distinguish context cancellation errors from other errors ([#3566](https://github.com/redis/go-redis/pull/3566))
+
+## ✨ New Features
+
+- Typed errors with wrapping support ([#3602](https://github.com/redis/go-redis/pull/3602)) by [@ndyakov](https://github.com/ndyakov)
+- CAS/CAD commands (marked as experimental) ([#3583](https://github.com/redis/go-redis/pull/3583), [#3595](https://github.com/redis/go-redis/pull/3595)) by [@ndyakov](https://github.com/ndyakov), [@htemelski-redis](https://github.com/htemelski-redis)
+- MSETEX command support ([#3580](https://github.com/redis/go-redis/pull/3580)) by [@ofekshenawa](https://github.com/ofekshenawa)
+- XReadGroup CLAIM argument ([#3578](https://github.com/redis/go-redis/pull/3578)) by [@ofekshenawa](https://github.com/ofekshenawa)
+- ACL commands: GenPass, Users, WhoAmI ([#3576](https://github.com/redis/go-redis/pull/3576)) by [@destinyoooo](https://github.com/destinyoooo)
+- SLOWLOG commands: LEN, RESET ([#3585](https://github.com/redis/go-redis/pull/3585)) by [@destinyoooo](https://github.com/destinyoooo)
+- LATENCY commands: LATEST, RESET ([#3584](https://github.com/redis/go-redis/pull/3584)) by [@destinyoooo](https://github.com/destinyoooo)
+- Hybrid search command (FT.HYBRID) ([#3573](https://github.com/redis/go-redis/pull/3573)) by [@htemelski-redis](https://github.com/htemelski-redis)
+- Vector range command (VRANGE) ([#3543](https://github.com/redis/go-redis/pull/3543)) by [@cxljs](https://github.com/cxljs)
+- Vector-specific attributes in FT.INFO ([#3596](https://github.com/redis/go-redis/pull/3596)) by [@ndyakov](https://github.com/ndyakov)
+- Improved connection pool success rate with FIFO queue ([#3518](https://github.com/redis/go-redis/pull/3518)) by [@cyningsun](https://github.com/cyningsun)
+- Canceled metrics attribute for context errors ([#3566](https://github.com/redis/go-redis/pull/3566)) by [@pvragov](https://github.com/pvragov)
+
+## 🐛 Bug Fixes
+
+- Fixed Failover Client MaintNotificationsConfig ([#3600](https://github.com/redis/go-redis/pull/3600)) by [@ajax16384](https://github.com/ajax16384)
+- Fixed ACLGenPass function to use the bit parameter ([#3597](https://github.com/redis/go-redis/pull/3597)) by [@destinyoooo](https://github.com/destinyoooo)
+- Return error instead of panic from commands ([#3568](https://github.com/redis/go-redis/pull/3568)) by [@dragneelfps](https://github.com/dragneelfps)
+- Safety harness in `joinErrors` to prevent panic ([#3577](https://github.com/redis/go-redis/pull/3577)) by [@manisharma](https://github.com/manisharma)
+
+## ⚡ Performance
+
+- Connection state machine with race condition fixes ([#3559](https://github.com/redis/go-redis/pull/3559)) by [@ndyakov](https://github.com/ndyakov)
+- Pool performance improvements: 47-67% faster Get/Put, 33% less memory, 50% fewer allocations ([#3565](https://github.com/redis/go-redis/pull/3565)) by [@ndyakov](https://github.com/ndyakov)
+
+## 🧪 Testing & Infrastructure
+
+- Updated to Redis 8.4.0 image ([#3603](https://github.com/redis/go-redis/pull/3603)) by [@ndyakov](https://github.com/ndyakov)
+- Added Redis 8.4-RC1-pre to CI ([#3572](https://github.com/redis/go-redis/pull/3572)) by [@ndyakov](https://github.com/ndyakov)
+- Refactored tests for idiomatic Go ([#3561](https://github.com/redis/go-redis/pull/3561), [#3562](https://github.com/redis/go-redis/pull/3562), [#3563](https://github.com/redis/go-redis/pull/3563)) by [@12ya](https://github.com/12ya)
+
+## 👥 Contributors
+
+We'd like to thank all the contributors who worked on this release!
+
+[@12ya](https://github.com/12ya), [@ajax16384](https://github.com/ajax16384), [@cxljs](https://github.com/cxljs), [@cyningsun](https://github.com/cyningsun), [@destinyoooo](https://github.com/destinyoooo), [@dragneelfps](https://github.com/dragneelfps), [@htemelski-redis](https://github.com/htemelski-redis), [@manisharma](https://github.com/manisharma), [@ndyakov](https://github.com/ndyakov), [@ofekshenawa](https://github.com/ofekshenawa), [@pvragov](https://github.com/pvragov)
+
+---
+
+**Full Changelog**: https://github.com/redis/go-redis/compare/v9.16.0...v9.17.0
+
 # 9.16.0 (2025-10-23)

 ## 🚀 Highlights
--- a/example/del-keys-without-ttl/go.mod
+++ b/example/del-keys-without-ttl/go.mod
@@ -5,7 +5,7 @@ go 1.18
 replace github.com/redis/go-redis/v9 => ../..

 require (
-	github.com/redis/go-redis/v9 v9.16.0
+	github.com/redis/go-redis/v9 v9.17.0
 	go.uber.org/zap v1.24.0
 )

--- a/example/digest-optimistic-locking/go.mod
+++ b/example/digest-optimistic-locking/go.mod
@@ -5,7 +5,7 @@ go 1.18
 replace github.com/redis/go-redis/v9 => ../..

 require (
-	github.com/redis/go-redis/v9 v9.16.0
+	github.com/redis/go-redis/v9 v9.17.0
 	github.com/zeebo/xxh3 v1.0.2
 )

--- a/example/hll/go.mod
+++ b/example/hll/go.mod
@@ -4,7 +4,7 @@ go 1.18

 replace github.com/redis/go-redis/v9 => ../..

-require github.com/redis/go-redis/v9 v9.16.0
+require github.com/redis/go-redis/v9 v9.17.0

 require (
 	github.com/cespare/xxhash/v2 v2.3.0 // indirect
--- a/example/hset-struct/go.mod
+++ b/example/hset-struct/go.mod
@@ -6,7 +6,7 @@ replace github.com/redis/go-redis/v9 => ../..

 require (
 	github.com/davecgh/go-spew v1.1.1
-	github.com/redis/go-redis/v9 v9.16.0
+	github.com/redis/go-redis/v9 v9.17.0
 )

 require (
--- a/example/lua-scripting/go.mod
+++ b/example/lua-scripting/go.mod
@@ -4,7 +4,7 @@ go 1.18

 replace github.com/redis/go-redis/v9 => ../..

-require github.com/redis/go-redis/v9 v9.16.0
+require github.com/redis/go-redis/v9 v9.17.0

 require (
 	github.com/cespare/xxhash/v2 v2.3.0 // indirect
--- a/example/otel/go.mod
+++ b/example/otel/go.mod
@@ -11,8 +11,8 @@ replace github.com/redis/go-redis/extra/redisotel/v9 => ../../extra/redisotel
 replace github.com/redis/go-redis/extra/rediscmd/v9 => ../../extra/rediscmd

 require (
-	github.com/redis/go-redis/extra/redisotel/v9 v9.16.0
-	github.com/redis/go-redis/v9 v9.16.0
+	github.com/redis/go-redis/extra/redisotel/v9 v9.17.0
+	github.com/redis/go-redis/v9 v9.17.0
 	github.com/uptrace/uptrace-go v1.21.0
 	go.opentelemetry.io/otel v1.22.0
 )
@@ -25,7 +25,7 @@ require (
 	github.com/go-logr/stdr v1.2.2 // indirect
 	github.com/golang/protobuf v1.5.3 // indirect
 	github.com/grpc-ecosystem/grpc-gateway/v2 v2.19.0 // indirect
-	github.com/redis/go-redis/extra/rediscmd/v9 v9.16.0 // indirect
+	github.com/redis/go-redis/extra/rediscmd/v9 v9.17.0 // indirect
 	go.opentelemetry.io/contrib/instrumentation/runtime v0.46.1 // indirect
 	go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.44.0 // indirect
 	go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.21.0 // indirect
--- a/example/redis-bloom/go.mod
+++ b/example/redis-bloom/go.mod
@@ -4,7 +4,7 @@ go 1.18

 replace github.com/redis/go-redis/v9 => ../..

-require github.com/redis/go-redis/v9 v9.16.0
+require github.com/redis/go-redis/v9 v9.17.0

 require (
 	github.com/cespare/xxhash/v2 v2.3.0 // indirect
--- a/example/scan-struct/go.mod
+++ b/example/scan-struct/go.mod
@@ -6,7 +6,7 @@ replace github.com/redis/go-redis/v9 => ../..

 require (
 	github.com/davecgh/go-spew v1.1.1
-	github.com/redis/go-redis/v9 v9.16.0
+	github.com/redis/go-redis/v9 v9.17.0
 )

 require (
--- a/example/throughput/throughput
+++ b/example/throughput/throughput
--- a/extra/rediscensus/go.mod
+++ b/extra/rediscensus/go.mod
@@ -7,8 +7,8 @@ replace github.com/redis/go-redis/v9 => ../..
 replace github.com/redis/go-redis/extra/rediscmd/v9 => ../rediscmd

 require (
-	github.com/redis/go-redis/extra/rediscmd/v9 v9.16.0
-	github.com/redis/go-redis/v9 v9.16.0
+	github.com/redis/go-redis/extra/rediscmd/v9 v9.17.0
+	github.com/redis/go-redis/v9 v9.17.0
 	go.opencensus.io v0.24.0
 )

--- a/extra/rediscmd/go.mod
+++ b/extra/rediscmd/go.mod
@@ -7,7 +7,7 @@ replace github.com/redis/go-redis/v9 => ../..
 require (
 	github.com/bsm/ginkgo/v2 v2.12.0
 	github.com/bsm/gomega v1.27.10
-	github.com/redis/go-redis/v9 v9.16.0
+	github.com/redis/go-redis/v9 v9.17.0
 )

 require (
--- a/extra/redisotel/go.mod
+++ b/extra/redisotel/go.mod
@@ -7,8 +7,8 @@ replace github.com/redis/go-redis/v9 => ../..
 replace github.com/redis/go-redis/extra/rediscmd/v9 => ../rediscmd

 require (
-	github.com/redis/go-redis/extra/rediscmd/v9 v9.16.0
-	github.com/redis/go-redis/v9 v9.16.0
+	github.com/redis/go-redis/extra/rediscmd/v9 v9.17.0
+	github.com/redis/go-redis/v9 v9.17.0
 	go.opentelemetry.io/otel v1.22.0
 	go.opentelemetry.io/otel/metric v1.22.0
 	go.opentelemetry.io/otel/sdk v1.22.0
--- a/extra/redisprometheus/go.mod
+++ b/extra/redisprometheus/go.mod
@@ -6,7 +6,7 @@ replace github.com/redis/go-redis/v9 => ../..

 require (
 	github.com/prometheus/client_golang v1.14.0
-	github.com/redis/go-redis/v9 v9.16.0
+	github.com/redis/go-redis/v9 v9.17.0
 )

 require (
--- a/internal/pool/pool.go
+++ b/internal/pool/pool.go
@@ -145,6 +145,7 @@ type ConnPool struct {
 	poolSize            atomic.Int32
 	idleConnsLen        atomic.Int32
 	idleCheckInProgress atomic.Bool
+	idleCheckNeeded     atomic.Bool

 	stats          Stats
 	waitDurationNs atomic.Int64
@@ -220,44 +221,62 @@ func (p *ConnPool) RemovePoolHook(hook PoolHook) {
 }

 func (p *ConnPool) checkMinIdleConns() {
+	// If a check is already in progress, mark that we need another check and return
 	if !p.idleCheckInProgress.CompareAndSwap(false, true) {
+		p.idleCheckNeeded.Store(true)
 		return
 	}
-	defer p.idleCheckInProgress.Store(false)

 	if p.cfg.MinIdleConns == 0 {
+		p.idleCheckInProgress.Store(false)
 		return
 	}

-	// Only create idle connections if we haven't reached the total pool size limit
-	// MinIdleConns should be a subset of PoolSize, not additional connections
-	for p.poolSize.Load() < p.cfg.PoolSize && p.idleConnsLen.Load() < p.cfg.MinIdleConns {
-		// Try to acquire a semaphore token
-		if !p.semaphore.TryAcquire() {
-			// Semaphore is full, can't create more connections
+	// Keep checking until no more checks are needed
+	// This handles the case where multiple Remove() calls happen concurrently
+	for {
+		// Clear the "check needed" flag before we start
+		p.idleCheckNeeded.Store(false)
+
+		// Only create idle connections if we haven't reached the total pool size limit
+		// MinIdleConns should be a subset of PoolSize, not additional connections
+		for p.poolSize.Load() < p.cfg.PoolSize && p.idleConnsLen.Load() < p.cfg.MinIdleConns {
+			// Try to acquire a semaphore token
+			if !p.semaphore.TryAcquire() {
+				// Semaphore is full, can't create more connections
+				p.idleCheckInProgress.Store(false)
+				return
+			}
+
+			p.poolSize.Add(1)
+			p.idleConnsLen.Add(1)
+			go func() {
+				defer func() {
+					if err := recover(); err != nil {
+						p.poolSize.Add(-1)
+						p.idleConnsLen.Add(-1)
+
+						p.freeTurn()
+						internal.Logger.Printf(context.Background(), "addIdleConn panic: %+v", err)
+					}
+				}()
+
+				err := p.addIdleConn()
+				if err != nil && err != ErrClosed {
+					p.poolSize.Add(-1)
+					p.idleConnsLen.Add(-1)
+				}
+				p.freeTurn()
+			}()
+		}
+
+		// If no one requested another check while we were working, we're done
+		if !p.idleCheckNeeded.Load() {
+			p.idleCheckInProgress.Store(false)
 			return
 		}

-		p.poolSize.Add(1)
-		p.idleConnsLen.Add(1)
-		go func() {
-			defer func() {
-				if err := recover(); err != nil {
-					p.poolSize.Add(-1)
-					p.idleConnsLen.Add(-1)
-
-					p.freeTurn()
-					internal.Logger.Printf(context.Background(), "addIdleConn panic: %+v", err)
-				}
-			}()
-
-			err := p.addIdleConn()
-			if err != nil && err != ErrClosed {
-				p.poolSize.Add(-1)
-				p.idleConnsLen.Add(-1)
-			}
-			p.freeTurn()
-		}()
+		// Otherwise, loop again to handle the new requests
 	}
 }

--- a/version.go
+++ b/version.go
@@ -2,5 +2,5 @@ package redis

 // Version is the current release version.
 func Version() string {
-	return "9.16.0"
+	return "9.17.0"
 }