mirror of
https://github.com/redis/go-redis.git
synced 2025-07-31 05:04:23 +03:00
utils: export ParseFloat and MustParseFloat wrapping internal utils (#3371)
* utils: expose ParseFloat via new public utils package * add tests for special float values in vector search
This commit is contained in:
30
internal/util/convert.go
Normal file
30
internal/util/convert.go
Normal file
@ -0,0 +1,30 @@
|
||||
package util
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"math"
|
||||
"strconv"
|
||||
)
|
||||
|
||||
// ParseFloat parses a Redis RESP3 float reply into a Go float64,
|
||||
// handling "inf", "-inf", "nan" per Redis conventions.
|
||||
func ParseStringToFloat(s string) (float64, error) {
|
||||
switch s {
|
||||
case "inf":
|
||||
return math.Inf(1), nil
|
||||
case "-inf":
|
||||
return math.Inf(-1), nil
|
||||
case "nan", "-nan":
|
||||
return math.NaN(), nil
|
||||
}
|
||||
return strconv.ParseFloat(s, 64)
|
||||
}
|
||||
|
||||
// MustParseFloat is like ParseFloat but panics on parse errors.
|
||||
func MustParseFloat(s string) float64 {
|
||||
f, err := ParseStringToFloat(s)
|
||||
if err != nil {
|
||||
panic(fmt.Sprintf("redis: failed to parse float %q: %v", s, err))
|
||||
}
|
||||
return f
|
||||
}
|
40
internal/util/convert_test.go
Normal file
40
internal/util/convert_test.go
Normal file
@ -0,0 +1,40 @@
|
||||
package util
|
||||
|
||||
import (
|
||||
"math"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestParseStringToFloat(t *testing.T) {
|
||||
tests := []struct {
|
||||
in string
|
||||
want float64
|
||||
ok bool
|
||||
}{
|
||||
{"1.23", 1.23, true},
|
||||
{"inf", math.Inf(1), true},
|
||||
{"-inf", math.Inf(-1), true},
|
||||
{"nan", math.NaN(), true},
|
||||
{"oops", 0, false},
|
||||
}
|
||||
|
||||
for _, tc := range tests {
|
||||
got, err := ParseStringToFloat(tc.in)
|
||||
if tc.ok {
|
||||
if err != nil {
|
||||
t.Fatalf("ParseFloat(%q) error: %v", tc.in, err)
|
||||
}
|
||||
if math.IsNaN(tc.want) {
|
||||
if !math.IsNaN(got) {
|
||||
t.Errorf("ParseFloat(%q) = %v; want NaN", tc.in, got)
|
||||
}
|
||||
} else if got != tc.want {
|
||||
t.Errorf("ParseFloat(%q) = %v; want %v", tc.in, got, tc.want)
|
||||
}
|
||||
} else {
|
||||
if err == nil {
|
||||
t.Errorf("ParseFloat(%q) expected error, got nil", tc.in)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
Reference in New Issue
Block a user