From 36157798ca494416fc57a53bc97be7eb7143cab8 Mon Sep 17 00:00:00 2001 From: Nedyalko Dyakov Date: Mon, 25 Aug 2025 10:28:46 +0300 Subject: [PATCH] fix example tests, pop more connections --- example_instrumentation_test.go | 12 ++++++------ internal/pool/pool.go | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/example_instrumentation_test.go b/example_instrumentation_test.go index 73248e4c..fa776fcf 100644 --- a/example_instrumentation_test.go +++ b/example_instrumentation_test.go @@ -57,8 +57,8 @@ func Example_instrumentation() { // finished dialing tcp :6379 // starting processing: <[hello 3]> // finished processing: <[hello 3]> - // starting processing: <[client maint_notifications on moving-endpoint-type external-ip]> - // finished processing: <[client maint_notifications on moving-endpoint-type external-ip]> + // starting processing: <[client maint_notifications on moving-endpoint-type internal-fqdn]> + // finished processing: <[client maint_notifications on moving-endpoint-type internal-fqdn]> // finished processing: <[ping]> } @@ -80,8 +80,8 @@ func ExamplePipeline_instrumentation() { // finished dialing tcp :6379 // starting processing: <[hello 3]> // finished processing: <[hello 3]> - // starting processing: <[client maint_notifications on moving-endpoint-type external-ip]> - // finished processing: <[client maint_notifications on moving-endpoint-type external-ip]> + // starting processing: <[client maint_notifications on moving-endpoint-type internal-fqdn]> + // finished processing: <[client maint_notifications on moving-endpoint-type internal-fqdn]> // pipeline finished processing: [[ping] [ping]] } @@ -103,8 +103,8 @@ func ExampleClient_Watch_instrumentation() { // finished dialing tcp :6379 // starting processing: <[hello 3]> // finished processing: <[hello 3]> - // starting processing: <[client maint_notifications on moving-endpoint-type external-ip]> - // finished processing: <[client maint_notifications on moving-endpoint-type external-ip]> + // starting processing: <[client maint_notifications on moving-endpoint-type internal-fqdn]> + // finished processing: <[client maint_notifications on moving-endpoint-type internal-fqdn]> // finished processing: <[watch foo]> // starting processing: <[ping]> // finished processing: <[ping]> diff --git a/internal/pool/pool.go b/internal/pool/pool.go index 70052220..359b6442 100644 --- a/internal/pool/pool.go +++ b/internal/pool/pool.go @@ -26,8 +26,8 @@ var ( // popAttempts is the maximum number of attempts to find a usable connection // when popping from the idle connection pool. This handles cases where connections // are temporarily marked as unusable (e.g., during hitless upgrades or network issues). - // Value of 10 provides sufficient resilience without excessive overhead. - popAttempts = 10 + // Value of 20 provides sufficient resilience without excessive overhead. + popAttempts = 20 // getAttempts is the maximum number of attempts to get a connection that passes // hook validation (e.g., hitless upgrade hooks). This protects against race conditions