redis/go-redis
1
0
Fork 0
mirror of https://github.com/redis/go-redis.git synced 2025-07-28 06:42:00 +03:00
Code Activity

fix: simplify api

Browse Source
This commit is contained in:
Nedyalko Dyakov
2025-06-27 22:25:36 +03:00
parent f7948b5c5c
commit 3473c1e998
7 changed files with 26 additions and 1521 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
push_notifications.go
View File

@ -8,18 +8,12 @@ import (
)
// PushNotificationHandler defines the interface for push notification handlers.
type PushNotificationHandler interface {
// HandlePushNotification processes a push notification.
// Returns true if the notification was handled, false otherwise.
HandlePushNotification(ctx context.Context, notification []interface{}) bool
}
// This is an alias to the internal push notification handler interface.
type PushNotificationHandler = pushnotif.Handler
// PushNotificationProcessorInterface defines the interface for push notification processors.
type PushNotificationProcessorInterface interface {
GetHandler(pushNotificationName string) PushNotificationHandler
ProcessPendingNotifications(ctx context.Context, rd *proto.Reader) error
RegisterHandler(pushNotificationName string, handler PushNotificationHandler, protected bool) error
}
// This is an alias to the internal push notification processor interface.
type PushNotificationProcessorInterface = pushnotif.ProcessorInterface
// PushNotificationRegistry manages push notification handlers.
type PushNotificationRegistry struct {
@ -49,8 +43,7 @@ func (r *PushNotificationRegistry) GetHandler(pushNotificationName string) PushN
if handler == nil {
return nil
}
// The handler is already a PushNotificationHandler since we store it directly
return handler.(PushNotificationHandler)
return handler
}
// GetRegisteredPushNotificationNames returns a list of all registered push notification names.
@ -58,10 +51,7 @@ func (r *PushNotificationRegistry) GetRegisteredPushNotificationNames() []string
return r.registry.GetRegisteredPushNotificationNames()
}
// HandleNotification attempts to handle a push notification using registered handlers.
func (r *PushNotificationRegistry) HandleNotification(ctx context.Context, notification []interface{}) bool {
return r.registry.HandleNotification(ctx, notification)
}
// PushNotificationProcessor handles push notifications with a registry of handlers.
type PushNotificationProcessor struct {
@ -100,12 +90,7 @@ func (p *PushNotificationProcessor) ProcessPendingNotifications(ctx context.Cont
return p.processor.ProcessPendingNotifications(ctx, rd)
}
// GetRegistryForTesting returns the push notification registry for testing.
func (p *PushNotificationProcessor) GetRegistryForTesting() *PushNotificationRegistry {
return &PushNotificationRegistry{
registry: p.processor.GetRegistryForTesting(),
}
}
// VoidPushNotificationProcessor discards all push notifications without processing them.
type VoidPushNotificationProcessor struct {
@ -134,11 +119,6 @@ func (v *VoidPushNotificationProcessor) ProcessPendingNotifications(ctx context.
return v.processor.ProcessPendingNotifications(ctx, rd)
}
// GetRegistryForTesting returns nil for void processor since it doesn't maintain handlers.
func (v *VoidPushNotificationProcessor) GetRegistryForTesting() *PushNotificationRegistry {
return nil
}
// Redis Cluster push notification names