Move logger to internal package.

internal/log.go

@@ -0,0 +1,22 @@
+package internal
+
+import (
+	"fmt"
+	"io/ioutil"
+	"log"
+)
+
+var Debug bool
+
+var Logger = log.New(ioutil.Discard, "redis: ", log.LstdFlags)
+
+func Debugf(s string, args ...interface{}) {
+	if !Debug {
+		return
+	}
+	Logger.Output(2, fmt.Sprintf(s, args...))
+}
+
+func Logf(s string, args ...interface{}) {
+	Logger.Output(2, fmt.Sprintf(s, args...))
+}

internal/pool/pool.go

@@ -3,17 +3,15 @@ package pool
 import (
 	"errors"
 	"fmt"
-	"io/ioutil"
-	"log"
 	"net"
 	"sync"
 	"sync/atomic"
 	"time"
 
 	"gopkg.in/bsm/ratelimit.v1"
-)
 
-var Logger = log.New(ioutil.Discard, "redis: ", log.LstdFlags)
+	"gopkg.in/redis.v4/internal"
+)
 
 var (
 	ErrClosed      = errors.New("redis: client is closed")
@@ -210,7 +208,7 @@ func (p *ConnPool) Put(cn *Conn) error {
 	if cn.Rd.Buffered() != 0 {
 		b, _ := cn.Rd.Peek(cn.Rd.Buffered())
 		err := fmt.Errorf("connection has unread data: %q", b)
-		Logger.Print(err)
+		internal.Logf(err.Error())
 		return p.Remove(cn, err)
 	}
 	p.freeConnsMu.Lock()
@@ -342,11 +340,11 @@ func (p *ConnPool) reaper(frequency time.Duration) {
 		}
 		n, err := p.ReapStaleConns()
 		if err != nil {
-			Logger.Printf("ReapStaleConns failed: %s", err)
+			internal.Logf("ReapStaleConns failed: %s", err)
 			continue
 		}
 		s := p.Stats()
-		Logger.Printf(
+		internal.Logf(
 			"reaper: removed %d stale conns (TotalConns=%d FreeConns=%d Requests=%d Hits=%d Timeouts=%d)",
 			n, s.TotalConns, s.FreeConns, s.Requests, s.Hits, s.Timeouts,
 		)